Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate AKS APIs from experimental #2959

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Graduate AKS APIs from experimental #2959

merged 1 commit into from
Jan 19, 2023

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Dec 20, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Based on criteria defined here:

This PR graduates the AKS APIs from experimental. The set of functional changes in this PR:

  • CAPZ's AKS feature flag has been deprecated (i.e., defaulted and locked to true), with a plan for removal in v1.12 of CAPZ
    • the AKS feature flag is no longer required for the AzureManagedCluster, AzureManagedControlPlane, and AzureManagedMachinePool resources
  • capi's MachinePool feature flag is required for the AzureManagedCluster, AzureManagedControlPlane, and AzureManagedMachinePool resources, and this is now being enforced via those resources' Create webhooks as well

The bulk of this PR changeset is moving the set of AKS APIs intact from the exp/ source directory (which indicates an "experimental" state of the APIs) to api/.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #2204
Fixes #3005

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

graduate AKS APIs from experimental

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 20, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2022
@jackfrancis jackfrancis force-pushed the aks-exp-to-v1beta1 branch 3 times, most recently from 6b7e9aa to 92e43aa Compare December 20, 2022 20:16
@jackfrancis jackfrancis changed the title WIP graduate AKS APIs from experimental Graduate AKS APIs from experimental Dec 20, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2022
@jackfrancis
Copy link
Contributor Author

/hold

until after v1.7.0 of capz is released

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@jackfrancis jackfrancis added this to the next milestone Dec 20, 2022
@jackfrancis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2023
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 3, 2023
@jackfrancis
Copy link
Contributor Author

/retest

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 3, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 18, 2023
@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9533ed5a09048404993e4f84492d70092b976dd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@CecileRobertMichon
Copy link
Contributor

/honk

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Contributor Author

/quack

@CecileRobertMichon
Copy link
Contributor

@jackfrancis opened #3055 to follow up on CSI migration job

@jackfrancis
Copy link
Contributor Author

/retest

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 18, 2023
@jackfrancis
Copy link
Contributor Author

/retest

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 19, 2023
@jackfrancis
Copy link
Contributor Author

/retest

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 19, 2023
@jackfrancis
Copy link
Contributor Author

/retest

1 similar comment
@jackfrancis
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 19, 2023 •
edited
Loading

@jackfrancis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff 216befe link false /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 14e368e into kubernetes-sigs:main Jan 19, 2023
@jackfrancis jackfrancis deleted the aks-exp-to-v1beta1 branch January 19, 2023 06:04
@CecileRobertMichon CecileRobertMichon mentioned this pull request Jan 23, 2023
Closed
3 tasks
@jackfrancis jackfrancis mentioned this pull request Jan 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@mboersma mboersma Awaiting requested review from mboersma

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@mboersma mboersma

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
7 participants
@jackfrancis @dtzar @CecileRobertMichon @mboersma @sonasingh46 @nojnhuh @k8s-ci-robot