Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary "Name" webhook from AzureManagedControlPlane #3005

Closed
jackfrancis opened this issue Jan 10, 2023 · 0 comments · Fixed by #2959
Closed

Remove unnecessary "Name" webhook from AzureManagedControlPlane #3005

jackfrancis opened this issue Jan 10, 2023 · 0 comments · Fixed by #2959
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@jackfrancis
Copy link
Contributor

/kind bug

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

We're currently validating immutability for the Name property with every webhook update flow for AzureManagedControlPlane. Because the Name property is the unique identifier for Kubernetes resource objects, and immutability is enforced at a lower abstraction layer, we should remove this unnecessary webhook.

This work was done in this PR, which did not land:

https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/2925/files#diff-794f776e55c518f77cccea935614365a8889a67d892918bd16d24f14fa0cbbc6L101-L107

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@jackfrancis jackfrancis added the area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 10, 2023
@jackfrancis jackfrancis added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 10, 2023
@nojnhuh nojnhuh mentioned this issue Jan 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Graduate AKS APIs from experimental jackfrancis/cluster-api-provider-azure
2 participants
@jackfrancis @k8s-ci-robot