Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clusterCIDR to cloud provider e2e install #2893

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add clusterCIDR to cloud provider e2e install #2893

merged 1 commit into from
Dec 9, 2022

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Dec 2, 2022 •
edited
Loading

What type of PR is this?

What this PR does / why we need it: Follow up from #2837, make sure we are the setting the right Cluster CIDRs in the CCM Helm chart install for OOT cloud-provider.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2852

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 2, 2022
@CecileRobertMichon
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-e2e

@jackfrancis
Copy link
Contributor

/retest

@jackfrancis jackfrancis added this to the v1.7 milestone Dec 7, 2022
@CecileRobertMichon
Copy link
Contributor Author

Going to push some docs and updates to Tilt then this will be ready for review/merge

@jackfrancis
Copy link
Contributor

@CecileRobertMichon feel free to assign to me when ready

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2022
@CecileRobertMichon
Copy link
Contributor Author

@jackfrancis this is ready for review, I'll make the Tilt changes in a separate PR

@CecileRobertMichon
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 8, 2022
@CecileRobertMichon
Copy link
Contributor Author

Tried to get fancy and add some tabs but it didn't work, this will have to do for now...

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2022
@jackfrancis
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-optional

mboersma
mboersma reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We took a similar approach in Azure/azure-capi-cli-extension#169 and it seems correct.

@CecileRobertMichon
Copy link
Contributor Author

CecileRobertMichon commented Dec 8, 2022 •
edited
Loading

Test looks good

I1208 17:49:47.648402 1 flags.go:64] FLAG: --cluster-cidr="192.168.0.0/16"

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/2893/pull-cluster-api-provider-azure-e2e-optional/1600906756119072768/artifacts/clusters/capz-e2e-rh9tfv-oot/kube-system/cloud-controller-manager-5bdf84f55-p4nxj/cloud-controller-manager.log

/assign @jackfrancis

jackfrancis
jackfrancis approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@CecileRobertMichon
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 64b9713 into kubernetes-sigs:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhecheng lzhecheng lzhecheng left review comments

@mboersma mboersma mboersma left review comments

@jackfrancis jackfrancis jackfrancis approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@jackfrancis jackfrancis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Set ClusterCIDR on CCM Helm chart values when installing cloud-provider in E2E
5 participants
@CecileRobertMichon @jackfrancis @k8s-ci-robot @mboersma @lzhecheng