Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud-provider-azure] Support specifying CCM cluster CIDR #2837

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[cloud-provider-azure] Support specifying CCM cluster CIDR #2837

merged 1 commit into from
Nov 30, 2022

Conversation

lzhecheng
Copy link
Contributor

Signed-off-by: Zhecheng Li [email protected]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
[cloud-provider-azure] Support specifying CCM cluster CIDR
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

[cloud-provider-azure] Support specifying CCM cluster CIDR

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2022
@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.6

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng force-pushed the support-dualstack-ccm branch from 3c83c45 to 92bec1b Compare November 21, 2022 14:20
@lzhecheng lzhecheng force-pushed the support-dualstack-ccm branch from 92bec1b to b4f1a62 Compare November 22, 2022 04:03
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2022
@lzhecheng lzhecheng force-pushed the support-dualstack-ccm branch from b4f1a62 to c25ce44 Compare November 23, 2022 00:21
@CecileRobertMichon
Copy link
Contributor

@lzhecheng tests are failing, please check

@lzhecheng lzhecheng force-pushed the support-dualstack-ccm branch 2 times, most recently from 483ae14 to 1918079 Compare November 23, 2022 02:16
@lzhecheng
Copy link
Contributor Author

@lzhecheng tests are failing, please check

PTAL

@lzhecheng lzhecheng force-pushed the support-dualstack-ccm branch from 1918079 to 87a981b Compare November 24, 2022 07:34
@lzhecheng
Copy link
Contributor Author

/retest

@lzhecheng lzhecheng force-pushed the support-dualstack-ccm branch from 87a981b to a088ef2 Compare November 28, 2022 06:51
CecileRobertMichon
CecileRobertMichon reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @jackfrancis

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@CecileRobertMichon CecileRobertMichon mentioned this pull request Nov 28, 2022
Closed
@jackfrancis
Copy link
Contributor

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot
Copy link

@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@jackfrancis
Copy link
Contributor

/hold

sorr @lzhecheng but let's get #2495 in first, which is a large change that's been waiting a long time in the queue :)

cc @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@CecileRobertMichon
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Nov 30, 2022 •
edited
Loading

/hold

we have a rebase err at main, need to fix it first nvm will fix the issue after this merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@jackfrancis
Copy link
Contributor

/hold cancel

we can actually land this first

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@CecileRobertMichon CecileRobertMichon mentioned this pull request Nov 30, 2022
Merged
3 tasks
@k8s-ci-robot k8s-ci-robot merged commit a5e418e into kubernetes-sigs:main Nov 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Nov 30, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 30, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #2876

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the support-dualstack-ccm branch November 30, 2022 04:59
@CecileRobertMichon CecileRobertMichon mentioned this pull request Dec 2, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jackfrancis jackfrancis jackfrancis left review comments

@devigned devigned Awaiting requested review from devigned

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@jackfrancis jackfrancis

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@lzhecheng @k8s-infra-cherrypick-robot @CecileRobertMichon @jackfrancis @k8s-ci-robot