Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calico to v3.24.1 #4176

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Mar 29, 2023

Update Calico to v3.24.1. May be related to failures in #4173

/kind cleanup

Update Calico to v3.24.1 

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

Still failing 😢

@killianmuldoon
Copy link
Contributor Author

I'll dive into the logs once the job is finished 🤔

@killianmuldoon
Copy link
Contributor Author

It looks like the kube-system/ebs-csi-controller-7547b54cd9-8zkqm pod can't be evicted because of its PodDisruptionBudget

I think it must be related to the changes in #4147 updating the ebs-csi, but I'm not certain.

@killianmuldoon
Copy link
Contributor Author

/hold

This shouldn't be merged until it's clear what it's actually doing and fixing.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2023
@killianmuldoon killianmuldoon changed the title Update Calico to v3.24.1 [WIP] Update Calico to v3.24.1 Mar 29, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2023
@Ankitasw
Copy link
Member

I think it must be related to the changes in #4147 updating the ebs-csi, but I'm not certain.

I will take a look at that and test in the other test PR.

@killianmuldoon
Copy link
Contributor Author

/pull-cluster-api-provider-aws-e2e

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@killianmuldoon
Copy link
Contributor Author

Passed after the changes to the ebs-csi yaml. @Ankitasw do you want to make those changes in your PR and I can revert this to just being a CNI update?

Honestly I'm not certain which of the changes had the impact - I made two. You might want to check which one is actually responsible in the fix (or I can do that in a different PR if you'd prefer).

@Ankitasw
Copy link
Member

Ankitasw commented Mar 29, 2023

Thankyou for finding the root cause @killianmuldoon I will raise a separate PR with this ebs-csi change. Lets keep this PR open with the calico update change, anyways its good to update that.

@Ankitasw
Copy link
Member

Ankitasw commented Mar 29, 2023

@killianmuldoon looks like the tests passed, you can revert the ebs-csi changes, and this PR would be good to go.

Thanks a lot again for doing this 🙇‍♀️

@killianmuldoon
Copy link
Contributor Author

Glad to hear it! I've reverted that change on this PR.

@killianmuldoon killianmuldoon changed the title [WIP] Update Calico to v3.24.1 Update Calico to v3.24.1 Mar 29, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2023
@Ankitasw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2023
@Ankitasw Ankitasw removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit bc8bdf3 into kubernetes-sigs:main Mar 29, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 29, 2023
@Ankitasw
Copy link
Member

Ankitasw commented Jun 5, 2023

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@Ankitasw: new pull request created: #4316

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants