-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Calico to v3.24.1 #4176
Update Calico to v3.24.1 #4176
Conversation
/test pull-cluster-api-provider-aws-e2e |
Still failing 😢 |
I'll dive into the logs once the job is finished 🤔 |
It looks like the I think it must be related to the changes in #4147 updating the ebs-csi, but I'm not certain. |
dcc6d41
to
6f51879
Compare
/hold This shouldn't be merged until it's clear what it's actually doing and fixing. |
I will take a look at that and test in the other test PR. |
/pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
Passed after the changes to the ebs-csi yaml. @Ankitasw do you want to make those changes in your PR and I can revert this to just being a CNI update? Honestly I'm not certain which of the changes had the impact - I made two. You might want to check which one is actually responsible in the fix (or I can do that in a different PR if you'd prefer). |
Thankyou for finding the root cause @killianmuldoon I will raise a separate PR with this ebs-csi change. Lets keep this PR open with the calico update change, anyways its good to update that. |
@killianmuldoon looks like the tests passed, you can revert the ebs-csi changes, and this PR would be good to go. Thanks a lot again for doing this 🙇♀️ |
6f51879
to
feb85b6
Compare
Glad to hear it! I've reverted that change on this PR. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
@Ankitasw: new pull request created: #4316 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update Calico to v3.24.1. May be related to failures in #4173
/kind cleanup