-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce GetDisk in AttachDisk #904
fix: reduce GetDisk in AttachDisk #904
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
afa780b
to
0b19e4f
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@andyzhangx could you enable the coveralls github comments (like kubernetes-sigs/cloud-provider-azure#678 (comment)), so the unit test coverage is shown automatically in the PR? |
@ZeroMagic do you know why it's broken? The code coverage code is actually copied from csi driver, did not figure out why only disk driver is broken, actually azure file, and blob csi drivers are all working. azuredisk-csi-driver/.github/workflows/linux.yml Lines 20 to 27 in 05768a8
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: reduce GetDisk in AttachDisk
refer to kubernetes-sigs/cloud-provider-azure#678
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: