Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce GetDisk in AttachDisk #904

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: reduce GetDisk in AttachDisk
refer to kubernetes-sigs/cloud-provider-azure#678

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: reduce GetDisk in AttachDisk

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2021
@andyzhangx
Copy link
Member Author

/retest

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 05768a8 into kubernetes-sigs:master Jun 28, 2021
@feiskyer
Copy link
Member

@andyzhangx could you enable the coveralls github comments (like kubernetes-sigs/cloud-provider-azure#678 (comment)), so the unit test coverage is shown automatically in the PR?

@andyzhangx
Copy link
Member Author

@andyzhangx could you enable the coveralls github comments (like kubernetes-sigs/cloud-provider-azure#678 (comment)), so the unit test coverage is shown automatically in the PR?

@ZeroMagic do you know why it's broken? The code coverage code is actually copied from csi driver, did not figure out why only disk driver is broken, actually azure file, and blob csi drivers are all working.

- name: Build Test
run: sudo go test -covermode=count -coverprofile=profile.cov ./pkg/...
- name: Send coverage
env:
COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
GO111MODULE=off go get github.com/mattn/goveralls
$(go env GOPATH)/bin/goveralls -coverprofile=profile.cov -service=github

edreed added a commit to abhisheksinghbaghel/azuredisk-csi-driver that referenced this pull request Jun 29, 2021
edreed added a commit to abhisheksinghbaghel/azuredisk-csi-driver that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants