Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge upstream changes 20210629 #95

Merged
merged 10 commits into from
Jun 30, 2021
Merged

Conversation

edreed
Copy link
Collaborator

@edreed edreed commented Jun 29, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. Merges changes from upstream as of 6/29/2021.
  2. Implements fix: reduce GetDisk in AttachDisk kubernetes-sigs/azuredisk-csi-driver#904 for CloudProvisioner.

Which issue(s) this PR fixes:

Requirements:

Special notes for your reviewer:

Release note:

none

@coveralls
Copy link

coveralls commented Jun 29, 2021

Pull Request Test Coverage Report for Build 983552101

  • 1 of 22 (4.55%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 36.209%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/azuredisk/azuredisk.go 0 9 0.0%
pkg/azuredisk/controllerserver.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/azuredisk/controllerserver.go 1 12.33%
pkg/azuredisk/azuredisk_v2.go 2 19.08%
Totals Coverage Status
Change from base Build 981092656: -0.006%
Covered Lines: 1192
Relevant Lines: 3292

💛 - Coveralls

@edreed edreed merged commit 4cafdf5 into master Jun 30, 2021
@edreed edreed deleted the edreed-merge-upstream-20210629 branch June 30, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants