fix: unit test failure on Windows #522

mayankshah1607 · 2020-09-06T08:12:37Z

Signed-off-by: Mayank Shah [email protected]

What type of PR is this?
/kind test
/kind cleanup

What this PR does / why we need it:
Fix unit test failures on Windows

Which issue(s) this PR fixes:

Fixes #520

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

k8s-ci-robot · 2020-09-06T08:12:44Z

Welcome @mayankshah1607!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-09-06T08:12:45Z

Hi @mayankshah1607. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mayankshah1607 · 2020-09-06T08:18:53Z

@andyzhangx PTAL! :)
Shall we also enable the Windows workflow? Looks like it is currently not running - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/.github/workflows/window

andyzhangx · 2020-09-06T08:21:19Z

pkg/azuredisk/azuredisk_test.go

@@ -544,6 +544,7 @@ func TestIsAvailabilityZone(t *testing.T) {
 }

 func TestIsCorruptedDir(t *testing.T) {
+	skipTestsIfWindows(t)


do you know how to configure this test in admin mode, actually this unit test TestIsCorruptedDir could pass in admin mode on Windows:

>go test -run TestIsCorruptedDir --- FAIL: TestIsCorruptedDir (0.00s) azuredisk_test.go:555: failed to create curruptedPath: symlink C:\Users\xiazhang\AppData\Local\Temp\csi-mount-test769943179 C:\Users\xiazhang\AppData\Local\Temp\csi-mount-test769943179\curruptedPath: A required privilege is not held by the client.

could be some setting in windows.yaml config:
https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/.github/workflows/window#L28

there is a possibility to use following runas command to solve this issue, while it still prompt password, need to figure it out later:
https://www.tenforums.com/general-support/111929-how-use-runas-without-password-prompt.html

C:\Users\xiazhang\go\src\sigs.k8s.io\azuredisk-csi-driver\pkg\azuredisk>runas /user:Administrator "go test -run TestIsCorruptedDir" Enter the password for Administrator:

@andyzhangx Just went through this issue thread - golang/dep#773
Seems like its an issue from the os.Symlink client library that's preventing the machine from creating Symlinks.
I tried running the test as administrator from Command promt and it seemed to PASS.

WDYT about skipping this test for now until we figure out a way to run as admin from the workflow?

andyzhangx · 2020-09-06T08:23:49Z

@andyzhangx PTAL! :)
Shall we also enable the Windows workflow? Looks like it is currently not running - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/.github/workflows/window

waiting for this PR: #521

andyzhangx · 2020-09-06T10:48:49Z

/ok-to-test

andyzhangx

pls also add a new line go test -v -race ./pkg/azuredisk/... under
or set as go test -v -race ./pkg/...

azuredisk-csi-driver/.github/workflows/windows.yml

Line 28 in dd9ecf7

go test -v -race ./pkg/mounter/...

andyzhangx · 2020-09-06T15:10:43Z

pkg/azuredisk/azure_test.go

 func TestGetCloudProvider(t *testing.T) {
+	skipTestsIfWindows(t)


rename as skipIfTestingOnWindows

Signed-off-by: Mayank Shah <[email protected]>

andyzhangx

/lgtm
/approve

k8s-ci-robot · 2020-09-07T01:32:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…e-e2e test: fix in-tree e2e test failure

k8s-ci-robot added kind/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 6, 2020

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2020

k8s-ci-robot requested review from andyzhangx and ZeroMagic September 6, 2020 08:12

andyzhangx reviewed Sep 6, 2020

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2020

andyzhangx reviewed Sep 6, 2020

View reviewed changes

mayankshah1607 added 3 commits September 6, 2020 20:55

fix: unit tests on Windows

82e9dcf

Signed-off-by: Mayank Shah <[email protected]>

rename to skipIfTestingOnWindows

9d40cd4

Signed-off-by: Mayank Shah <[email protected]>

fix workflow

a922d6c

Signed-off-by: Mayank Shah <[email protected]>

mayankshah1607 force-pushed the mayank/fix-windows-tests branch from 11f2293 to a922d6c Compare September 6, 2020 15:27

skip TestEnsureMountPoint on Windows

24df3ee

Signed-off-by: Mayank Shah <[email protected]>

andyzhangx approved these changes Sep 7, 2020

View reviewed changes

k8s-ci-robot assigned andyzhangx Sep 7, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020

andyzhangx mentioned this pull request Sep 7, 2020

fix TestIsCorruptedDir unit test on Windows #524

Closed

andyzhangx merged commit dd1d746 into kubernetes-sigs:master Sep 7, 2020

mayankshah1607 mentioned this pull request Oct 27, 2020

REQUEST: New membership for mayankshah1607 kubernetes/org#2290

Closed

6 tasks

sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021

Merge pull request kubernetes-sigs#522 from kubernetes-sigs/fix-intre…

0931677

…e-e2e test: fix in-tree e2e test failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: unit test failure on Windows #522

fix: unit test failure on Windows #522

mayankshah1607 commented Sep 6, 2020 •

edited

Loading

k8s-ci-robot commented Sep 6, 2020

k8s-ci-robot commented Sep 6, 2020

mayankshah1607 commented Sep 6, 2020 •

edited

Loading

andyzhangx Sep 6, 2020 •

edited

Loading

andyzhangx Sep 6, 2020

andyzhangx Sep 6, 2020

mayankshah1607 Sep 6, 2020

andyzhangx Sep 6, 2020

andyzhangx commented Sep 6, 2020

andyzhangx commented Sep 6, 2020

andyzhangx left a comment •

edited

Loading

andyzhangx Sep 6, 2020

andyzhangx left a comment

k8s-ci-robot commented Sep 7, 2020

		func TestGetCloudProvider(t *testing.T) {
		skipTestsIfWindows(t)

fix: unit test failure on Windows #522

fix: unit test failure on Windows #522

Conversation

mayankshah1607 commented Sep 6, 2020 • edited Loading

k8s-ci-robot commented Sep 6, 2020

k8s-ci-robot commented Sep 6, 2020

mayankshah1607 commented Sep 6, 2020 • edited Loading

andyzhangx Sep 6, 2020 • edited Loading

Choose a reason for hiding this comment

andyzhangx Sep 6, 2020

Choose a reason for hiding this comment

andyzhangx Sep 6, 2020

Choose a reason for hiding this comment

mayankshah1607 Sep 6, 2020

Choose a reason for hiding this comment

andyzhangx Sep 6, 2020

Choose a reason for hiding this comment

andyzhangx commented Sep 6, 2020

andyzhangx commented Sep 6, 2020

andyzhangx left a comment • edited Loading

Choose a reason for hiding this comment

andyzhangx Sep 6, 2020

Choose a reason for hiding this comment

andyzhangx left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 7, 2020

mayankshah1607 commented Sep 6, 2020 •

edited

Loading

mayankshah1607 commented Sep 6, 2020 •

edited

Loading

andyzhangx Sep 6, 2020 •

edited

Loading

andyzhangx left a comment •

edited

Loading