Merge pull request #521 from andyzhangx/windows-ut-pipeline

test: add Windows unit test pipeline
kubernetes-sigs · Sep 6, 2020 · dd9ecf7 · dd9ecf7
2 parents f6950cd + 887e4ff
commit dd9ecf7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/.github/workflows/window → .github/workflows/windows.yml b/.github/workflows/window → .github/workflows/windows.yml
@@ -25,4 +25,6 @@ jobs:
           go build -a -o _output/azurediskplugin.exe ./pkg/azurediskplugin
       - name: Run Windows Unit Tests
         run: |
-          go test -v -race ./pkg/... ./test/utils/credentials      
+          go test -v -race ./pkg/mounter/...
+          go test -v -race ./pkg/util/...
+          go test -v -race ./pkg/csi-common/...
diff --git a/pkg/azuredisk/azure_common_test.go b/pkg/azuredisk/azure_common_test.go
@@ -18,13 +18,14 @@ package azuredisk
 
 import (
 	"fmt"
-	api "k8s.io/kubernetes/pkg/apis/core"
 	"os"
 	"runtime"
 	"strings"
 	"testing"
 	"time"
 
+	api "k8s.io/kubernetes/pkg/apis/core"
+
 	"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2019-12-01/compute"
 	"github.com/stretchr/testify/assert"
 
@@ -122,8 +123,8 @@ func (handler *fakeIOHandler) ReadFile(filename string) ([]byte, error) {
 }
 
 func TestIoHandler(t *testing.T) {
-	if runtime.GOOS != "windows" && runtime.GOOS != "linux" {
-		t.Skipf("TestIoHandler not supported on GOOS=%s", runtime.GOOS)
+	if runtime.GOOS == "windows" {
+		t.Skipf("skip test on GOOS=%s", runtime.GOOS)
 	}
 	disk, err := findDiskByLun(lun, &fakeIOHandler{}, nil)
 	if runtime.GOOS == "windows" {

diff --git a/pkg/azuredisk/nodeserver_test.go b/pkg/azuredisk/nodeserver_test.go
@@ -22,6 +22,7 @@ import (
 	"fmt"
 	"os"
 	"reflect"
+	"runtime"
 	"syscall"
 	"testing"
 
@@ -30,7 +31,7 @@ import (
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
 
-	"k8s.io/utils/exec/testing"
+	testingexec "k8s.io/utils/exec/testing"
 	"k8s.io/utils/mount"
 
 	"sigs.k8s.io/azuredisk-csi-driver/pkg/mounter"
@@ -232,6 +233,10 @@ func TestNodeGetVolumeStats(t *testing.T) {
 }
 
 func TestNodeStageVolume(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skipf("skip test on GOOS=%s", runtime.GOOS)
+	}
+
 	stdVolCap := &csi.VolumeCapability_Mount{
 		Mount: &csi.VolumeCapability_MountVolume{
 			FsType: defaultLinuxFsType,