Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Workload identity is not working. #2233

Merged
merged 1 commit into from
Mar 23, 2024
Merged

fix: Workload identity is not working. #2233

merged 1 commit into from
Mar 23, 2024

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Mar 20, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: Workload identity is not working.
Which issue(s) this PR fixes:

Fixes #2229

Requirements:

Special notes for your reviewer:

Release note:

fix: Workload identity is not working.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2024
andyzhangx
andyzhangx reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to add a test for this? at least adding a ut since this is not covered in e2e test now

@andyzhangx andyzhangx removed the request for review from edreed March 20, 2024 07:11
@cvvz
Copy link
Member Author

cvvz commented Mar 20, 2024

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2024
@cvvz
Copy link
Member Author

cvvz commented Mar 20, 2024

is there any way to add a test for this? at least adding a ut since this is not covered in e2e test now

I've added a ut for running with workload identity test scenario, please take a look.

@andyzhangx
Copy link
Member

could you squash all commits and then make same fix on other CSI drivers? thanks.

@cvvz
Squashed commit of the following:
f270e57 
commit e5fc454
Author: weizhichen <[email protected]>
Date:   Fri Mar 22 02:50:20 2024 +0000

    fix ut

commit c187396
Merge: db238de fda1d0a
Author: weizhichen <[email protected]>
Date:   Fri Mar 22 02:33:37 2024 +0000

    Merge branch 'master' of github.com:kubernetes-sigs/azuredisk-csi-driver into fix-workload-identity

commit db238de
Author: weizhichen <[email protected]>
Date:   Wed Mar 20 09:07:45 2024 +0000

    add ut

commit 68c19d6
Author: weizhichen <[email protected]>
Date:   Wed Mar 20 06:30:58 2024 +0000

    fix
@cvvz cvvz force-pushed the fix-workload-identity branch from e5fc454 to f270e57 Compare March 22, 2024 03:48
@andyzhangx
Copy link
Member

/retest

andyzhangx
andyzhangx approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@andyzhangx
Copy link
Member

/retest

4 similar comments
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@cvvz
Copy link
Member Author

cvvz commented Mar 23, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 86f17d5 into kubernetes-sigs:master Mar 23, 2024
25 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.30

@andyzhangx
Copy link
Member

/cherrypick release-1.29

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #2236

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 24, 2024
Merged
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 24, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #2237

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload identity is not working
4 participants
@cvvz @andyzhangx @k8s-ci-robot @k8s-infra-cherrypick-robot