Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload identity is not working #2229

Closed
AdallomRoy opened this issue Mar 17, 2024 · 2 comments · Fixed by #2233
Closed

Workload identity is not working #2229

AdallomRoy opened this issue Mar 17, 2024 · 2 comments · Fixed by #2233
Assignees

Comments

@AdallomRoy
Copy link

AdallomRoy commented Mar 17, 2024

What happened: Workload identity is not working

What you expected to happen: Workload identity should work

How to reproduce it: Try to use workload identity

Anything else we need to know?:

Since this commit: https://github.com/wiz-sec/azuredisk-csi-driver/commit/01b0efc4be6b8963eeff0fcd0c5a35f3edeb5545 workload identity is broken, since ParseConfig is not called anymore and therefore this code part:

if tenantID := os.Getenv("AZURE_TENANT_ID"); tenantID != "" {
	config.TenantID = tenantID
}
if clientID := os.Getenv("AZURE_CLIENT_ID"); clientID != "" {
	config.AADClientID = clientID
}
if federatedTokenFile := os.Getenv("AZURE_FEDERATED_TOKEN_FILE"); federatedTokenFile != "" {
	config.AADFederatedTokenFile = federatedTokenFile
	config.UseFederatedWorkloadIdentityExtension = true
}

does not get called anymore.

Environment:

  • CSI Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@andyzhangx
Copy link
Member

/assign @cvvz

@cvvz
Copy link
Member

cvvz commented Mar 20, 2024

Hi, @AdallomRoy Thanks for your report. I've filed a PR to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants