Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #607

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Update README.md #607

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89e3035
Update README.md
robisoh88 Nov 5, 2020
2c119ef
Update README.md
robisoh88 Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/kubernetes/snapshot/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ This driver implements basic volume snapshotting functionality using the [extern

1. The `VolumeSnapshotDataSource` must be set in `--feature-gates=` in the `kube-apiserver`.

1. The [aws-ebs-csi-driver driver](https://github.com/kubernetes-sigs/aws-ebs-csi-driver) is installed.
1. The [aws-ebs-csi-driver driver](https://github.com/kubernetes-sigs/aws-ebs-csi-driver) with alpha features is installed.
1. If your cluster does not come pre-installed with Snapshot Beta CRDs, install the [Snapshot Beta CRDs](https://github.com/kubernetes-csi/external-snapshotter/tree/master/client/config/crd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be more useful to link directly to installation part of their README: https://github.com/kubernetes-csi/external-snapshotter#usage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayberk , I agree on this especially should any further changes be made on where their files are stored in the future it would be better to link directly to their README. Please see the new commit.


### Usage

Expand Down