-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #607
Update README.md #607
Conversation
The prerequisites can be updated to install the ebs-csi-driver with alpha features and another prerequisite should include installing Snapshot Beta CRDs if the cluster does not come pre0installed with it.
Welcome @robisoh88! |
Hi @robisoh88. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @jsafrane |
Pull Request Test Coverage Report for Build 1307
💛 - Coveralls |
I signed it |
@@ -10,7 +10,8 @@ This driver implements basic volume snapshotting functionality using the [extern | |||
|
|||
1. The `VolumeSnapshotDataSource` must be set in `--feature-gates=` in the `kube-apiserver`. | |||
|
|||
1. The [aws-ebs-csi-driver driver](https://github.com/kubernetes-sigs/aws-ebs-csi-driver) is installed. | |||
1. The [aws-ebs-csi-driver driver](https://github.com/kubernetes-sigs/aws-ebs-csi-driver) with alpha features is installed. | |||
1. If your cluster does not come pre-installed with Snapshot Beta CRDs, install the [Snapshot Beta CRDs](https://github.com/kubernetes-csi/external-snapshotter/tree/master/client/config/crd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be more useful to link directly to installation part of their README: https://github.com/kubernetes-csi/external-snapshotter#usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ayberk , I agree on this especially should any further changes be made on where their files are stored in the future it would be better to link directly to their README. Please see the new commit.
/ok-to-test Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, robisoh88 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
No
What is this PR about? / Why do we need it?
Volume Snapshots README.md is missing steps to install Volume Snapshot beta CRDs (volumesnapshotclass, volumesnapshotcontents, volumesnapshots). Following the Volume Snapshot example alone does not work. Need to update the document. See below for more info.
What testing is done?
Following the guide without having CRDs EBS CSI Driver fails with "VolumeSnapshotClass not in "snapshot.storage.k8s.io/v1beta1""(see issue). Moreover the EBS CSI Driver with Alpha features is the correct driver that need to be installed. Installing the stable version of the ebs csi driver will not include external snapshotter sidecar, snapshot controller or service account/RBAC. Pull request is to mention this in the Volume Snapshot example README.