Volume metrics #524

Henni · 2020-06-16T12:08:31Z

Is this a bug fix or adding new feature?
New Feature

What is this PR about? / Why do we need it?
Implementation of NodeGetVolumeStats to report volume metrics:

kubelet_volume_stats_available_bytes
kubelet_volume_stats_capacity_bytes
kubelet_volume_stats_inodes
kubelet_volume_stats_inodes_free
kubelet_volume_stats_inodes_used
kubelet_volume_stats_used_bytes

What testing is done?
Linting is fine.
I wasn't able to fully run the tests yet. I believe this is because the tests only run properly on Linux.

k8s-ci-robot · 2020-06-16T12:08:35Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-06-16T12:08:38Z

Welcome @Henni!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-06-16T12:08:39Z

Hi @Henni. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2020-06-16T12:11:48Z

Pull Request Test Coverage Report for Build 1446

21 of 74 (28.38%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.9%) to 79.776%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/driver/node.go	21	74	28.38%

Totals
Change from base Build 1442:	-1.9%
Covered Lines:	1641
Relevant Lines:	2057

💛 - Coveralls

Henni · 2020-06-16T12:25:05Z

/check-cla

leakingtapan · 2020-06-26T06:14:54Z

@Henni thx for the contribution!
/ok-to-test

gnufied · 2020-06-30T19:43:01Z

pkg/driver/statter.go

+	inodesFree = int64(statfs.Ffree)
+	inodesUsed = inodes - inodesFree
+	return
+}


Is there a way we can reuse code from core k8s to do this rather than copying similar logic here? We can consider moving these utility functions somewhere common where all CSI drivers can use them.

fejta-bot · 2020-09-28T20:17:34Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

mindw · 2020-09-29T06:28:17Z

/remove-lifecycle stale

A requirement achieving production grade?

batas · 2020-12-10T13:55:00Z

@Henni could you finish your work? This PR is really nice and would be very helpful in my job :) I saw in other drivers this functionality is successfully implemented.

Henni · 2020-12-10T14:02:20Z

This issue is still on my list. I hope to get back to it next week.

I based this work on kubernetes-sigs/gcp-compute-persistent-disk-csi-driver@ead3152 implementation.

k8s-ci-robot · 2021-01-08T13:00:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Henni
To complete the pull request process, please assign ayberk after the PR has been reviewed.
You can assign the PR to them by writing /assign @ayberk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2021-01-08T13:05:55Z

@Henni: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-aws-ebs-csi-driver-unit	`342eae0`	link	`/test pull-aws-ebs-csi-driver-unit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Henni · 2021-01-08T13:05:55Z

Rebased and removed the statter.go
Instead I am now reusing generic kubernetes code.

cc @matthiaslee @AndyXiangLi
I am ok with applying my changes to any other Pull Request that is currently open (like #677)

Henni · 2021-01-13T09:05:34Z

fixed with #677

k8s-ci-robot · 2021-01-13T09:05:41Z

@Henni: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 16, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2020

k8s-ci-robot requested review from jsafrane and leakingtapan June 16, 2020 12:08

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 16, 2020

gnufied reviewed Jun 30, 2020

View reviewed changes

This was referenced Sep 23, 2020

[FEATURE] Prometheus support longhorn/longhorn#1180

Closed

[FEATURE] Support kublet_volume_* metrics longhorn/longhorn#1821

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2020

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2020

matthiaslee mentioned this pull request Oct 14, 2020

WIP: Rebasing PR #524, Volume metrics #589

Closed

dpc and others added 4 commits January 8, 2021 13:41

Report volume usage metrics

855492b

I based this work on kubernetes-sigs/gcp-compute-persistent-disk-csi-driver@ead3152 implementation.

Fix unit tests

67e04eb

expose capability, fix, and log metrics

fc2f066

refactor to remove statter

58f07fb

fix go.sum from rebase

342eae0

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2021

Henni closed this Jan 13, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2021

robcxyz mentioned this pull request Mar 30, 2022

Volume metrics vultr/vultr-csi#67

Closed

erdembas mentioned this pull request Jun 16, 2022

Volume metrics vmware/cloud-director-named-disk-csi-driver#62

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Volume metrics #524

Volume metrics #524

Henni commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

coveralls commented Jun 16, 2020 •

edited

Loading

Henni commented Jun 16, 2020

leakingtapan commented Jun 26, 2020

gnufied Jun 30, 2020

fejta-bot commented Sep 28, 2020

mindw commented Sep 29, 2020

batas commented Dec 10, 2020

Henni commented Dec 10, 2020

k8s-ci-robot commented Jan 8, 2021

k8s-ci-robot commented Jan 8, 2021 •

edited

Loading

Henni commented Jan 8, 2021

Henni commented Jan 13, 2021

k8s-ci-robot commented Jan 13, 2021

Volume metrics #524

Volume metrics #524

Conversation

Henni commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

k8s-ci-robot commented Jun 16, 2020

coveralls commented Jun 16, 2020 • edited Loading

Pull Request Test Coverage Report for Build 1446

💛 - Coveralls

Henni commented Jun 16, 2020

leakingtapan commented Jun 26, 2020

gnufied Jun 30, 2020

Choose a reason for hiding this comment

fejta-bot commented Sep 28, 2020

mindw commented Sep 29, 2020

batas commented Dec 10, 2020

Henni commented Dec 10, 2020

k8s-ci-robot commented Jan 8, 2021

k8s-ci-robot commented Jan 8, 2021 • edited Loading

Henni commented Jan 8, 2021

Henni commented Jan 13, 2021

k8s-ci-robot commented Jan 13, 2021

coveralls commented Jun 16, 2020 •

edited

Loading

k8s-ci-robot commented Jan 8, 2021 •

edited

Loading