Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Metrics for the driver #223

Closed
leakingtapan opened this issue Feb 24, 2019 · 21 comments · Fixed by #677
Closed

Report Metrics for the driver #223

leakingtapan opened this issue Feb 24, 2019 · 21 comments · Fixed by #677
Milestone

Comments

@leakingtapan
Copy link
Contributor

leakingtapan commented Feb 24, 2019

Is your feature request related to a problem? Please describe.
Report Metrics for the driver

Describe the solution you'd like in detail
TBD

Ref

@leakingtapan leakingtapan added this to the GA milestone Feb 24, 2019
@leakingtapan leakingtapan modified the milestones: 0.4, 0.5 Mar 31, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2019
@leakingtapan
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2019
@frittentheke
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2020
@zerkms
Copy link
Contributor

zerkms commented Jan 20, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2020
@leakingtapan leakingtapan modified the milestones: 0.5, 0.6 Feb 23, 2020
@rgarcia89
Copy link

Awesome to see that this will be part of milestone 0.6
very looking forward to it

This was referenced Jun 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2020
@zerkms
Copy link
Contributor

zerkms commented Jul 14, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2020
@leakingtapan leakingtapan modified the milestones: 0.6, 0.7 Aug 9, 2020
@AceHack
Copy link

AceHack commented Oct 1, 2020

What's going on here, how do we get metrics, this seems very incomplete without it.

@konduktor4ik
Copy link

Any update?

@AceHack
Copy link

AceHack commented Dec 4, 2020

Any update, I really hope this is done before 1.19 when CSIMigrationAWS is likely to be enabled. This will break tons of our alarms and auto-resizing code if we can't get metrics.

@Ramneekkhurana
Copy link

can we have any updates on this ?

@ayberk
Copy link
Contributor

ayberk commented Dec 24, 2020

We're currently not actively working on this but we understand how important it is. I'll see if we can get some resources soon.

@AceHack I believe currently it's planned to be on by default with 1.21 release.

@AceHack
Copy link

AceHack commented Jan 4, 2021

Any update?

This was referenced Jan 4, 2021
@AceHack
Copy link

AceHack commented Jan 12, 2021

Great updates, thanks so much for the work on this.

@kovalyukm
Copy link

Please, tell in which version of the driver and when volume stats metrics are going to be available? (For now #677 is in master only).

@ayberk
Copy link
Contributor

ayberk commented Feb 1, 2021

We'll have it in the next release, so 0.9.0.

@Pluies
Copy link

Pluies commented Apr 13, 2021

For those wondering (as I did!) what metrics are now available, as I couldn't find any info about them in this project's docs, they are the standard:

kubelet_volume_stats_inodes_used
kubelet_volume_stats_used_bytes
kubelet_volume_stats_available_bytes
kubelet_volume_stats_capacity_bytes
kubelet_volume_stats_inodes
kubelet_volume_stats_inodes_free

And they're exposed on the kubelet metrics endpoint without any extra config. So if you have e.g. Prometheus scraping the kubelet, the metrics should be available already! 👍

Thank you for adding this @AndyXiangLi , it's super helpful 🙏

jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this issue Apr 26, 2023
…ci-lint

OCPBUGS-12297: UPSTREAM: 1505: bump go + golangci-lint
@augustovictor
Copy link

Even though these metrics are now available, are they collected by cloudwatch as well or it'd be necessary to configure prometheus to scrape them, for example?

@ghost
Copy link

ghost commented Jun 5, 2024

I'm in a similar situation like @augustovictor - my EBS driver is deployed as an addon via Terraform.
I also have enabled CloudWatch integration (addon) with Container Insights.
Running commands such as kubectl get --raw /api/v1/nodes/(HOST)/proxy/metrics | grep 'kubelet_volume_stats_available_bytes' does indeed show metrics but how do I get these metrics into CloudWatch so I can create alarms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet