Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sanity tests #288

Merged
merged 2 commits into from
May 13, 2019
Merged

Update sanity tests #288

merged 2 commits into from
May 13, 2019

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Apr 30, 2019 •
edited
Loading

Is this a bug fix or adding new feature?

/kind bug

What is this PR about? / Why do we need it?

Update CSI sanity library and fix the fake cloud implementation to return an error if snapshot doesn't exist. This is a requirement to test #271.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2019
@coveralls
Copy link

coveralls commented Apr 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 626

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.12%
Totals Coverage Status
Change from base Build 625: 0.0%
Covered Lines: 1086
Relevant Lines: 1527
💛 - Coveralls

@bertinatto bertinatto mentioned this pull request Apr 30, 2019
Closed
@bertinatto bertinatto changed the title [WIP] Update sanity tests Update sanity tests May 3, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2019
@bertinatto
Copy link
Member Author

I just removed the WIP label to unblock #271.

/assign @leakingtapan
PTAL

leakingtapan
leakingtapan reviewed May 5, 2019
View reviewed changes
Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification.

go.mod Show resolved Hide resolved
@bertinatto bertinatto mentioned this pull request May 7, 2019
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2019
@bertinatto
Copy link
Member Author

/test pull-aws-ebs-csi-driver-integration

@tsmetana
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tsmetana: changing LGTM is restricted to assignees, and only kubernetes-sigs/aws-ebs-csi-driver repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leakingtapan
leakingtapan reviewed May 13, 2019
View reviewed changes
Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit e067f70 into kubernetes-sigs:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bertinatto @k8s-ci-robot @coveralls @tsmetana @leakingtapan