Return error if snapshot doesn't exist

[bertinatto]

/kind bug

What happened?

It seems like we're not returning a status.NotFound error when CreateVolume is given a non-existent snapshot ID.

https://github.com/kubernetes-csi/csi-test/blob/e1f2421c7f0a0cc7f9942fea1192392f253891db/pkg/sanity/controller.go#L738

CC @tsmetana @leakingtapan

[bertinatto]

My guess is that AWS will return an InvalidSnapshot.NotFound error. In that case, we just have to return an cloud.ErrNotFound in CreateDisk; and in CreateVolume return an status.NotFound.

[tsmetana]

/assign

[k8s-ci-robot]

@tsmetana: GitHub didn't allow me to assign the following users: tsmetana.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tsmetana]

The strange thing is that the test suite complains about controller returning nil not a wrong error. I'll take a look at this.

[bertinatto]

The strange thing is that the test suite complains about controller returning nil not a wrong error. I'll take a look at this.

Yes, I fixed that in #288. However, in addition to fixing the fake cloud implementation (ie #288), we need to make sure this is fixed in cloud.go as well.

[tsmetana]

Yes, I fixed that in #288. However, in addition to fixing the fake cloud implementation (ie #288), we need to make sure this is fixed in cloud.go as well.

OK. So we miss the error "translation". Thanks for explaining.

[leakingtapan]

/close

[k8s-ci-robot]

@leakingtapan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.