Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge snapshot to master branch #218

Merged
merged 4 commits into from
Feb 20, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
merge snapshot to master branch and resolved conflict happened during merge

What is this PR about? / Why do we need it?
Ref

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2019
@k8s-ci-robot k8s-ci-robot requested a review from ddebroy February 18, 2019 18:59
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 18, 2019
@leakingtapan leakingtapan changed the title Snapshot Merge snapshot to master branch Feb 18, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 454

  • 116 of 205 (56.59%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 63.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/controller.go 43 67 64.18%
pkg/cloud/cloud.go 73 100 73.0%
pkg/cloud/fakes.go 0 38 0.0%
Totals Coverage Status
Change from base Build 448: -0.7%
Covered Lines: 893
Relevant Lines: 1401

💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-integration

@leakingtapan
Copy link
Contributor Author

/cc @tsmetana

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: GitHub didn't allow me to request PR reviews from the following users: tsmetana.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tsmetana

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsmetana
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tsmetana: changing LGTM is restricted to assignees, and only kubernetes-sigs/aws-ebs-csi-driver repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ddebroy
Copy link

ddebroy commented Feb 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit b8fa1e6 into kubernetes-sigs:master Feb 20, 2019
@leakingtapan leakingtapan deleted the snapshot branch February 20, 2019 04:50
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request Apr 26, 2023
…ency-openshift-4.14-ose-aws-ebs-csi-driver

Updating ose-aws-ebs-csi-driver images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants