Don't wait for the snapshot to be completed #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Pull Request Test Coverage Report for Build 440
💛 - Coveralls |
Pull Request Test Coverage Report for Build 450
💛 - Coveralls |
pkg/cloud/cloud.go
Outdated
| @@ -732,7 +740,7 @@ func (c *cloud) waitForSnapshotCreate(ctx context.Context, snapshotID *string) e | |||
| case "completed": | |||
| return true, nil | |||
| case "pending": | |||
| return false, nil | |||
| return true, nil | |||
There was a problem hiding this comment.
Since we are always returning true here, do we still need this waitForSnapshotCreate when creating snapshot? Can we just check the snapshot state returned from the CreateSnapshotWithContext?
There was a problem hiding this comment.
Yes, this is rather paranoid -- I only wanted to be sure DescribeSnapshotsWithContext can find the newly created snapshot.
| SnapshotID: aws.StringValue(ec2Snapshot.SnapshotId), | ||
| SourceVolumeID: aws.StringValue(ec2Snapshot.VolumeId), | ||
| Size: snapshotSize, | ||
| CreationTime: aws.TimeValue(ec2Snapshot.StartTime), | ||
| } | ||
| if aws.StringValue(ec2Snapshot.State) == "completed" { | ||
| snapshot.ReadyToUse = true |
There was a problem hiding this comment.
Suggested change
| snapshot.ReadyToUse = true | |
| snapshot.ReadyToUse = aws.StringValue(ec2Snapshot.State) == "completed" |
|
/cc @dkoshkin |
tsmetana
force-pushed
the
snapshot-return-pending
branch
from
0a0872a to
128122b
Compare
k8s-ci-robot
added
size/M
|
OK. I've removed the waiting method. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, tsmetana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Feb 18, 2019
jsafrane
pushed a commit
to jsafrane/aws-ebs-csi-driver
that referenced
this pull request
Jul 18, 2023
…t/cherry-pick-208-to-release-4.11 [release-4.11] OCPBUGS-1749: UPSTREAM: 1398: Add resolver to handle custom endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the way the snapshots are being created: Originally the driver waited for the snapshot to complete. This is wrong since the snapshot creation may take a really long time. Also the gRPC would most likely timeout (the call is meant to be blocking) and cause all kinds of other problems.
Now the driver retruns the snapshot as soon as it appears in EC2 with ReadyToUse state in
falseand updates the state accordingly when the controller calls the SnapshotCreate again with the same parameters.