-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kustomize e2e test #1735
Add kustomize e2e test #1735
Conversation
@AndrewSirenko: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Connor Catlett <[email protected]>
66a1013
to
3658e90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
This PR adds a new parameter to
hack/run/e2e.sh
called$DEPLOY_METHOD
. This parameter supports"helm"
(the default and existing method) and"kustomize"
(newly added for this PR) to specify the method that the EBS CSI Driver is deployed for testing.It uses this parameter to crate a new make target,
test-e2e-external-kustomize
- which runs the e2e tests with a Kustomize installation of the driver.What testing is done?
Manually tested locally, additionally will start as optional when flipped on in
test-infra
:Test locally via
make
(replaceBUCKET_NAME
with the name of an S3 bucket that exists and you have access to):