Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomize e2e test #1735

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

ConnorJC3
Copy link
Contributor

Is this a bug fix or adding new feature?

New feature

What is this PR about? / Why do we need it?

This PR adds a new parameter to hack/run/e2e.sh called $DEPLOY_METHOD. This parameter supports "helm" (the default and existing method) and "kustomize" (newly added for this PR) to specify the method that the EBS CSI Driver is deployed for testing.

It uses this parameter to crate a new make target, test-e2e-external-kustomize - which runs the e2e tests with a Kustomize installation of the driver.

What testing is done?

Manually tested locally, additionally will start as optional when flipped on in test-infra:

Ran 83 of 7486 Specs in 305.820 seconds
SUCCESS! -- 83 Passed | 0 Failed | 0 Pending | 7403 Skipped
...
###
## SUCCESS!
#

Test locally via make (replace BUCKET_NAME with the name of an S3 bucket that exists and you have access to):

KOPS_STATE_FILE=s3://BUCKET_NAME make test-e2e-external-kustomize

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Connor Catlett <[email protected]>
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit aedf5da into kubernetes-sigs:master Sep 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants