Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws-ebs-csi-driver kustomize presubmit; Switch aws-ebs-csi-driver windows test to non-optional #30676

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

ConnorJC3
Copy link
Contributor

/hold
Depends on kubernetes-sigs/aws-ebs-csi-driver#1735

  • Commit 1: Adds a presubmit job for the aws-ebs-csi-driver to test on Kustomize
  • Commit 2: Sets previously optional aws-ebs-csi-driver windows tests to non-optional

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@torredil
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@ConnorJC3
Copy link
Contributor Author

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 86d92b9 into kubernetes:master Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml

In response to this:

/hold
Depends on kubernetes-sigs/aws-ebs-csi-driver#1735

  • Commit 1: Adds a presubmit job for the aws-ebs-csi-driver to test on Kustomize
  • Commit 2: Sets previously optional aws-ebs-csi-driver windows tests to non-optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants