Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change flag for PULL_NUMBER with test-integration #172

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Change flag for PULL_NUMBER with test-integration #172

merged 2 commits into from
Jan 7, 2019

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Jan 7, 2019

I do not have write access to @kschumy's repository, thus creating a one.

Is this a bug fix or adding new feature?
Bug fix

What is this PR about? / Why do we need it?
The flag needed for PULL_NUMBER for test-integration is changing. See: aws/aws-k8s-tester#31

What testing is done?
Local

Closes: #170.

/cc @leakingtapan

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2019
@gyuho gyuho changed the title Code Issues 26 Pull requests 8 Projects 0 Wiki Insights Change flag for PULL_NUMBER with test-integration Change flag for PULL_NUMBER with test-integration Jan 7, 2019
@gyuho
Copy link
Member Author

gyuho commented Jan 7, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

@gyuho
Copy link
Member Author

gyuho commented Jan 7, 2019

We need kubernetes/test-infra#10636 for this PR to work.

@gyuho
Copy link
Member Author

gyuho commented Jan 7, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2019
@gyuho
Copy link
Member Author

gyuho commented Jan 7, 2019

/retest

1 similar comment
@leakingtapan
Copy link
Contributor

/retest

@leakingtapan
Copy link
Contributor

Thanks @gyuho for the quick fix

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyuho, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 431a31e into kubernetes-sigs:master Jan 7, 2019
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request Jan 6, 2021
…verification

Bug 1872251: Upstream: 555: Vendor deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants