-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change flag for PULL_NUMBER with test-integration #170
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kschumy If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kschumy. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm @leakingtapan We've changed the name of the flag in aws/aws-k8s-tester#31. I will cut the release soon with the fix merged in. |
1 similar comment
/retest |
@kschumy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@kschumy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@leakingtapan This will fail until we release the new version. I will cut the release on Monday. Still have some pending PRs to be merged before the release. /hold |
Bug 1871683: UPSTREAM: 550: Clarify error message when unsupported volume capabilities are provided
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
The flag needed for PULL_NUMBER for test-integration is changing. See: aws/aws-k8s-tester#31
What testing is done?
Local