Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change flag for PULL_NUMBER with test-integration #170

Closed
wants to merge 1 commit into from

Conversation

kschumy
Copy link

@kschumy kschumy commented Jan 4, 2019

Is this a bug fix or adding new feature?
Bug fix

What is this PR about? / Why do we need it?
The flag needed for PULL_NUMBER for test-integration is changing. See: aws/aws-k8s-tester#31

What testing is done?
Local

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kschumy
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jsafrane

If they are not already assigned, you can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kschumy. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2019
@gyuho
Copy link
Member

gyuho commented Jan 4, 2019

/lgtm

@leakingtapan We've changed the name of the flag in aws/aws-k8s-tester#31. I will cut the release soon with the fix merged in.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 304

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 304

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.352%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

@kschumy
Copy link
Author

kschumy commented Jan 4, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

@kschumy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2019
@k8s-ci-robot
Copy link
Contributor

@kschumy: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-aws-ebs-csi-driver-integration 4c48a7c link /test pull-aws-ebs-csi-driver-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyuho
Copy link
Member

gyuho commented Jan 5, 2019

@leakingtapan This will fail until we release the new version. I will cut the release on Monday. Still have some pending PRs to be merged before the release.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2019
huffmanca pushed a commit to huffmanca/aws-ebs-csi-driver that referenced this pull request Sep 25, 2020
Bug 1871683: UPSTREAM: 550: Clarify error message when unsupported volume capabilities are provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants