Add opentelemetry tracing of gRPC calls

[Fricounet]

Is this a bug fix or adding new feature?
This PR adds support for opentelemetry tracing in the driver. The feature is opt-in behind a feature flag --enable-otel-tracing.

What is this PR about? / Why do we need it?
Adds basic tracing instrumentation focused around the gRPC calls by using an opentelemetry lib to intercept the calls automatically. However, some more in-depth instrumentation could be added at a later date.
The chart was also updated to allow users to use this new feature.
Closes #1691

What testing is done?
This change has been running in Datadog's AWS clusters for a month without any issue. Below is a screenshot of an example of a captured trace.

[k8s-ci-robot]

Welcome @Fricounet!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Fricounet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[torredil]

/ok-to-test

[Fricounet]

Hi @torredil looking at the failing tests,

• pull-aws-ebs-csi-driver-test-e2e-external-eks-windows seem to have been failing on all the recent runs. Should I ignore it?
• pull-aws-ebs-csi-driver-test-helm-chart has the following: Error: UPGRADE FAILED: template: aws-ebs-csi-driver/templates/node.yaml:67:26: executing "aws-ebs-csi-driver/templates/node.yaml" at <.Values.node.otelTracing.enabled>: nil pointer evaluating interface {}.enabled. For some reason, the values I set in charts/aws-ebs-csi-driver/values.yaml do not seem to be picked up. Do you know what is missing? 😅

[torredil]

Hi @Fricounet you may ignore the pull-aws-ebs-csi-driver-test-e2e-external-eks-windows failures, that specific job is currently configured as optional and thus will not block your PR.

As for fixing the helm error, I suggest modifying the scope using with:

{{- with .Values.foo }}
  {{- .bar }}
{{- end }}

[Fricounet]

@torredil thanks for your help, test are green now :)
I created a separate commit to fix the tests but if you prefer a cleaner git history, I can squash the commit.
The PR should be ready for review now.

[torredil]

@Fricounet Glad to hear!

I can squash the commit

That would be great, thank you.

[ConnorJC3]

/lgtm

[ConnorJC3]

/cc @torredil

anything left on this one besides squashing the commits?

[torredil]

@Fricounet This looks great. Will merge once the commits have been squashed, thanks!

[Fricounet]

Squash done, thanks for your review :)

[k8s-ci-robot]

@Fricounet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows	85f0103	link	false	/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ConnorJC3]

/lgtm

[torredil]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment