Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otel trace instrumentation on gRPC calls #1691

Closed
Fricounet opened this issue Jul 17, 2023 · 1 comment · Fixed by #1714
Closed

Add otel trace instrumentation on gRPC calls #1691

Fricounet opened this issue Jul 17, 2023 · 1 comment · Fixed by #1714

Comments

@Fricounet
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Add some more observability to the csi driver. In particular, add gRPC tracing using opentelemetry.

Describe the solution you'd like in detail
We implemented it in our fork. So I can submit the same PR here.

Describe alternatives you've considered
None

Additional context
Add any other context or screenshots about the feature request here.

@ConnorJC3
Copy link
Contributor

ConnorJC3 commented Aug 7, 2023

Hi @Fricounet - we discussed this and we'd definitely be open to accepting a PR for otel tracing. It will have to go through the normal PR review process, and DataDog will have to sign the standard CLA assigning the copyright to the Kubernetes project. Feel free to open a PR and we'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants