-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c6i.metal and g5g.metal are nitro instances #1358
Conversation
Signed-off-by: Wayne Mesard <[email protected]>
Hi @wmesard. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rdpsin, torredil, wmesard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Wayne Mesard [email protected]
Is this a bug fix or adding new feature?
Bug
What is this PR about? / Why do we need it?
An earlier version of the Available instance types list was unclear on whether
c6i.metal
andg5g.metal
. They are. And the docs now say so unambiguously. This PR updates the code to match the doc (and reality).What testing is done?
make && make test