Skip to content

Commit

Permalink
Merge pull request #1358 from wmesard/master
Browse files Browse the repository at this point in the history
c6i.metal and g5g.metal are nitro instances
  • Loading branch information
k8s-ci-robot authored Aug 24, 2022
2 parents ec30592 + 8d428e5 commit 3da851e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
11 changes: 0 additions & 11 deletions pkg/cloud/volume_limits.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ const (
nitroMaxAttachments = 28
)

// / It is possible to have an instance family where the virtualized instances are Nitro
// / and metal instances are not
var nonNitroInstances = map[string]struct{}{
"c6i.metal": {},
"g5g.metal": {},
}

// / List of nitro instance types can be found here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
var nonNitroInstanceFamilies = map[string]struct{}{
"t2": {},
Expand All @@ -41,10 +34,6 @@ var nonNitroInstanceFamilies = map[string]struct{}{
}

func IsNitroInstanceType(it string) bool {
if _, ok := nonNitroInstances[it]; ok {
return false
}

strs := strings.Split(it, ".")

if len(strs) != 2 {
Expand Down
2 changes: 1 addition & 1 deletion pkg/driver/node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1991,7 +1991,7 @@ func TestNodeGetInfo(t *testing.T) {
region: "us-west-2",
volumeAttachLimit: -1,
attachedENIs: 1,
expMaxVolumes: 31,
expMaxVolumes: 27, // 28 (max) - 1 (eni)
outpostArn: emptyOutpostArn,
},
{
Expand Down

0 comments on commit 3da851e

Please sign in to comment.