Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from next branch #134

Merged
merged 10 commits into from
Dec 3, 2018
Merged

Merge from next branch #134

merged 10 commits into from
Dec 3, 2018

Conversation

leakingtapan
Copy link
Contributor

Code freeze is lifted. Just merge next branch to master.

After this we can switch back to work on master

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 3, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 208

  • 2 of 14 (14.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 51.173%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/identity.go 0 1 0.0%
pkg/driver/node.go 0 5 0.0%
pkg/driver/controller.go 2 8 25.0%
Totals Coverage Status
Change from base Build 206: -0.09%
Covered Lines: 567
Relevant Lines: 1108

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 208

  • 2 of 14 (14.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 51.173%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/identity.go 0 1 0.0%
pkg/driver/node.go 0 5 0.0%
pkg/driver/controller.go 2 8 25.0%
Totals Coverage Status
Change from base Build 206: -0.09%
Covered Lines: 567
Relevant Lines: 1108

💛 - Coveralls

@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2018
@bertinatto bertinatto merged commit fdc019d into master Dec 3, 2018
@leakingtapan leakingtapan deleted the next branch January 6, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants