Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CSI 1.0 #122

Merged
merged 7 commits into from
Nov 29, 2018
Merged

Update to CSI 1.0 #122

merged 7 commits into from
Nov 29, 2018

Conversation

bertinatto
Copy link
Member

Is this a bug fix or adding new feature?

/kind feature

What is this PR about? / Why do we need it?

This PR updates the driver to the new CSI 1.0 spec.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2018
@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 191

  • 2 of 14 (14.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 51.305%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/identity.go 0 1 0.0%
pkg/driver/node.go 0 5 0.0%
pkg/driver/controller.go 2 8 25.0%
Totals Coverage Status
Change from base Build 185: 0.05%
Covered Lines: 570
Relevant Lines: 1111

💛 - Coveralls

@bertinatto
Copy link
Member Author

/assign @leakingtapan

@bertinatto
Copy link
Member Author

/hold
I'll take the chance and remove the vendor dir instead of updating it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2018
@bertinatto
Copy link
Member Author

/hold cancel

Apparently we have to keep the vendor directory because the tests aren't using go 1.11 yet.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2018
@leakingtapan
Copy link
Contributor

Is this PR tested against v1.13?

@bertinatto
Copy link
Member Author

Yes, it' s only tested against v1.13.

@bertinatto bertinatto changed the base branch from master to next November 29, 2018 08:28
@bertinatto
Copy link
Member Author

I just changed the base branch for this PR from master to next.

@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit da7e111 into kubernetes-sigs:next Nov 29, 2018
leakingtapan pushed a commit to leakingtapan/ebs-csi-driver that referenced this pull request Dec 4, 2018
Fixes: kubernetes-sigs#137

I use latest instead of v1.13 to highlight that is the latest version
under development which might have issues. And any other versioned
manifest files should not break.
k8s-ci-robot added a commit that referenced this pull request Dec 5, 2018
Partially revert PR #122 and add latest manifest files
bertinatto pushed a commit to bertinatto/aws-ebs-csi-driver that referenced this pull request Dec 12, 2018
Fixes: kubernetes-sigs#137

I use latest instead of v1.13 to highlight that is the latest version
under development which might have issues. And any other versioned
manifest files should not break.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants