-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for volume to become available #126
Wait for volume to become available #126
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 186
💛 - Coveralls |
Pull Request Test Coverage Report for Build 232
💛 - Coveralls |
/hold This can only be merged after #122 because there's conflict with CSI v0. |
12fed13
to
b86c7ad
Compare
/hold cancel Actually, no. The real problem was that |
b86c7ad
to
ffb98ea
Compare
/retest |
ffb98ea
to
a739d75
Compare
I just changed the base branch for this PR from |
@@ -1,144 +1,128 @@ | |||
// Code generated by MockGen. DO NOT EDIT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment, did we use a different version of MockGen so that the content are different from the previous generated code? Which MockGen are you using? Could you add some documentation about this in docs folder. Or we can do this in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was the same version as before, but apparently it had some incompatibilities with go modules. I had to update the imports of this file manually (not good).
I updated the deps to their last minor versions and now it works fine.
a739d75
to
b993902
Compare
b993902
to
a5d56c1
Compare
/lgtm |
Is this a bug fix or adding new feature?
/kind bug
What is this PR about? / Why do we need it?
This patch waits for the volume to become
available
whenCreateVolume
is called. This prevents the CO from trying to attach the volume when
it's still being created.
Fixes #65.
/assign @leakingtapan