Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for volume to become available #126

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

bertinatto
Copy link
Member

Is this a bug fix or adding new feature?

/kind bug

What is this PR about? / Why do we need it?

This patch waits for the volume to become available when CreateVolume
is called. This prevents the CO from trying to attach the volume when
it's still being created.

Fixes #65.

/assign @leakingtapan

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 186

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.08%) to 50.181%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/cloud.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
pkg/cloud/cloud.go 13 66.67%
Totals Coverage Status
Change from base Build 185: -1.08%
Covered Lines: 556
Relevant Lines: 1108

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 28, 2018

Pull Request Test Coverage Report for Build 232

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 50.352%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/cloud.go 8 9 88.89%
Totals Coverage Status
Change from base Build 231: 0.4%
Covered Lines: 572
Relevant Lines: 1136

💛 - Coveralls

@bertinatto
Copy link
Member Author

/hold

This can only be merged after #122 because there's conflict with CSI v0.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2018
@bertinatto
Copy link
Member Author

/hold cancel

Actually, no. The real problem was that gomock wasn't generating the correct import paths.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@bertinatto
Copy link
Member Author

/retest

@bertinatto bertinatto changed the base branch from master to next November 29, 2018 08:29
@bertinatto
Copy link
Member Author

I just changed the base branch for this PR from master to next.

@bertinatto bertinatto mentioned this pull request Dec 3, 2018
@bertinatto bertinatto changed the base branch from next to master December 3, 2018 10:27
@@ -1,144 +1,128 @@
// Code generated by MockGen. DO NOT EDIT.
Copy link
Contributor

@leakingtapan leakingtapan Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, did we use a different version of MockGen so that the content are different from the previous generated code? Which MockGen are you using? Could you add some documentation about this in docs folder. Or we can do this in a separate PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was the same version as before, but apparently it had some incompatibilities with go modules. I had to update the imports of this file manually (not good).

I updated the deps to their last minor versions and now it works fine.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2018
@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8d6b057 into kubernetes-sigs:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement wait for volume create/delete
4 participants