Fix unable to create CSI snapshot-EBS csi driver #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Torres <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
torredil
removed
the
approved
ghost
approved these changes
Jun 1, 2022
k8s-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MurphyPuppy, rdpsin, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
oh, I realized that you need to bump up helm chart version manually. I checked github action failed. |
|
Yes, will need a new Helm release to apply the sidecar bumping up. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eddie Torres [email protected]
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
csi-snapshottertov6.0.1which fixes "Failed to watch *v1beta1.VolumeSnapshotClass: failed to list *v1beta1.VolumeSnapshotClass: the server could not find the requested resource (get volumesnapshotclasses.snapshot.storage.k8s.io)" when attempting to create a snapshot, as support forv1beta1has been removed.patchto verbs list incharts/aws-ebs-csi-driver/templates/clusterrole-snapshotter.yamlanddeploy/kubernetes/base/clusterrole-snapshotter.yaml.csi-snapshotter
v6.0.1has not been published to public ECR: https://gallery.ecr.aws/eks-distro/kubernetes-csi/external-snapshotter/csi-snapshotter, hence usingv5.0.1in the overlay.What testing is done?