Don't install snapshot controller

[wongma7]

/kind bug

What happened? Snapshot controller is installed by helm.

What you expected to happen? Snapshot controller should not be installed, the driver should reuse an existing installation of snapshot controller, since the controller might be reused by other drivers. Or helm could somehow check if the controller already exists. Trying to install it again can cause conflict issues.

How to reproduce it (as minimally and precisely as possible)? do helm install

Anything else we need to know?: see also #601

Environment

• Kubernetes version (use kubectl version):
• Driver version:

[wongma7]

I think the issue is we haven't ujpdated the yamls ever since snapshot controller gto split into a sidecar and separate controller. It's still a bug because we are out of date for not doing so!!

[ayberk]

This confused me when I was updating the sidecars for the arm overlay. Unless someone else picks it up by then, I'll do this as part of updating sidecar images.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

Our chart's handling of snapshotter controller and CRDs is causing a lot of headaches for both users and maintainers (i have spent way too much time thinking and writing comments about it -_-). I intend to remove the CRDs and controller and simply list it as a prerequisite to the chart. As of 1.20 kops will install the controller and CRDs by default. Other distros may do the same. Users whose distros don't will have to install themselves, we'll link them to https://github.com/kubernetes-csi/external-snapshotter

[wongma7]

/remove lifecycle-rotten

[wongma7]

/remove-lifecycle rotten

[krmichel]

/assign