Helm chart : snapshot-controller image location is hardcoded, we should be able to set overwrite the value

[JonathanLachapelle]

Is your feature request related to a problem?/Why is this needed
It is not possible to use the helm chart with a private repository

/feature

Describe the solution you'd like in detail
Add the possibility in the snapshot controller stateful set to input the image location

Describe alternatives you've considered
Fork the repo

[JonathanLachapelle]

Also ImagePullSecret is not working

[JonathanLachapelle]

I created a pull request to fix this issue : #583

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[wongma7]

Actually it is a mistake that the helm chart installs snapshot controller at all. I got confused myself, cuz there is the snapshot controller and then there is the snapshot sidecar...... REF, contiunue discussion there:
Don't install snapshot controller #635