This repository has been archived by the owner on Oct 16, 2018. It is now read-only.
컨트리뷰션 가이드라인 및 저장소 설명 업데이트 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
gochist
force-pushed
the
readme-contributing
branch
from
6634efb to
5b931cd
Compare
Closed
|
/assign @ianychoi |
ianychoi
reviewed
Aug 16, 2018
README.md
Outdated
|
|
||
| 다음의 연락처를 통해 이 프로젝트의 메인테이너에게 연락할 수 있습니다. | ||
|
|
||
| - [Slack](http://slack.k8s.io/) |
There was a problem hiding this comment.
How about "#kubernetes-docs-ko channel in Slack - Kubernetes "?
gochist
force-pushed
the
readme-contributing
branch
from
5b931cd to
43dbece
Compare
|
Thank you, @ianychoi. Addressed your comment. |
|
/lgtm |
|
테스트입니다. 승인이 안 되어야 맞는거겠죠? /approve |
|
/approve |
|
/assign @claudiajkang 전 reviewer라서.. :) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ClaudiaJKang, ianychoi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2