-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node.serviceAccount setting in chart config #488
fix: node.serviceAccount setting in chart config #488
Conversation
|
Welcome @steveizzle! |
Hi @steveizzle. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e5b7541
to
714536b
Compare
714536b
to
39e9a9f
Compare
Signed-off-by: steveizzle <[email protected]>
hey @andyzhangx can you please check and do you think that this can make it in the next release? |
@steveizzle it does not need to be in next release, I already worked out a PR to fix it in v1.7.0 release since this is just chart config change: #494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, steveizzle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 2434826733
💛 - Coveralls |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The SA can be configured on the values.yaml but the value is not used in the template
Which issue(s) this PR fixes:
Relates to #480
Special notes for your reviewer:
I saw too late that this is missing in #480 :(
Release note: