Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node.serviceAccount setting in chart config #488

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

steveizzle
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

The SA can be configured on the values.yaml but the value is not used in the template

Which issue(s) this PR fixes:

Relates to #480

Special notes for your reviewer:

I saw too late that this is missing in #480 :(

Release note:

none

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 1, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: steveizzle / name: Stefan Riembauer (e5b7541)

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @steveizzle!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @steveizzle. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 1, 2022
@steveizzle steveizzle force-pushed the fix/node-sa-values branch from e5b7541 to 714536b Compare June 3, 2022 13:15
@steveizzle steveizzle force-pushed the fix/node-sa-values branch from 714536b to 39e9a9f Compare June 3, 2022 13:16
Signed-off-by: steveizzle <[email protected]>
@steveizzle
Copy link
Contributor Author

hey @andyzhangx can you please check and do you think that this can make it in the next release?

@andyzhangx
Copy link
Member

hey @andyzhangx can you please check and do you think that this can make it in the next release?

@steveizzle it does not need to be in next release, I already worked out a PR to fix it in v1.7.0 release since this is just chart config change: #494

@andyzhangx andyzhangx changed the title Added variables from values file fix: node.serviceAccount setting in chart config Jun 4, 2022
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 4, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, steveizzle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2434826733

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.498%

Totals Coverage Status
Change from base Build 2433038230: 0.0%
Covered Lines: 774
Relevant Lines: 916

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit c495e08 into kubernetes-csi:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants