Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add serviceAccount for driver daemonset running on the node #480

Merged
merged 1 commit into from
May 15, 2022
Merged

fix: add serviceAccount for driver daemonset running on the node #480

merged 1 commit into from
May 15, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
chore: add serviceAccount for driver daemonset running on the node
it's required on RedHat Openshift: https://github.com/kubernetes-csi/csi-driver-nfs/pull/334/files#r868940032

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: add serviceAccount for driver daemonset running on the node

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2300851473

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.498%
Totals Coverage Status
Change from base Build 2288818218: 0.0%
Covered Lines: 774
Relevant Lines: 916
💛 - Coveralls

@andyzhangx andyzhangx merged commit 4e99bc9 into kubernetes-csi:master May 15, 2022
@steveizzle
Copy link
Contributor

steveizzle commented May 23, 2022 •
edited
Loading

hey @andyzhangx, when is the new release planned, which includes this fix?

@andyzhangx
Copy link
Member Author

hey @andyzhangx, when is the new release planned, which includes this fix?

@steveizzle does this PR fix the issue on OpenShift?

@steveizzle
Copy link
Contributor

hey @andyzhangx, when is the new release planned, which includes this fix?

@steveizzle does this PR fix the issue on OpenShift?

Honestly I don't know, but this helps also when using PSPs or something equivalent bound to service accounts

@andyzhangx
Copy link
Member Author

hey @andyzhangx, when is the new release planned, which includes this fix?

@steveizzle does this PR fix the issue on OpenShift?

Honestly I don't know, but this helps also when using PSPs or something equivalent bound to service accounts

@steveizzle ok, let me publish a new release this week.

@steveizzle steveizzle mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @k8s-ci-robot @coveralls @steveizzle