Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from testing before first release #24

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Changes from testing before first release #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dc9f66
Fix deprecated API group for StatefulSet
wozniakjan Feb 28, 2020
50d5f44
Remove csi-attacher
wozniakjan Mar 5, 2020
748602f
Update driver version
wozniakjan Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions deploy/kubernetes/csi-attacher-nfsplugin.yaml
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions deploy/kubernetes/csi-attacher-rbac.yaml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions deploy/kubernetes/csi-nfs-driverinfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: storage.k8s.io/v1beta1
kind: CSIDriver
metadata:
name: csi-nfsplugin
spec:
attachRequired: false
volumeLifecycleModes:
- Persistent
podInfoOnMount: true
2 changes: 1 addition & 1 deletion deploy/kubernetes/csi-nodeplugin-nfsplugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This YAML file contains driver-registrar & csi driver nodeplugin API objects
# that are necessary to run CSI nodeplugin for nfs
kind: DaemonSet
apiVersion: apps/v1beta2
apiVersion: apps/v1
metadata:
name: csi-nodeplugin-nfsplugin
spec:
Expand Down
2 changes: 1 addition & 1 deletion pkg/nfs/nfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const (
)

var (
version = "1.0.0-rc2"
version = "1.0.0"
Copy link
Member Author

@wozniakjan wozniakjan Mar 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also noticed this while glancing through the code. Probably worth at some point deriving this from git tag/sha in a similar fashion that kubectl does during build process?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the csi build tools does support injecting git tag into the version: https://github.com/kubernetes-csi/csi-release-tools/blob/master/build.make#L77

We just need to fix this up to use that. We can do that in a followup

)

func NewNFSdriver(nodeID, endpoint string) *nfsDriver {
Expand Down