Changes from testing before first release

[wozniakjan]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Eventually this should lead to a fully tested release of v1.0.0 with up-to-date documentation.

Currently this is a placeholder for WIP to inform the status and the fact it hasn't been abandoned, just lacking free time to finish testing this :)
Changes that spawned up from testing, confirmed to be working fine and able to bind and mount PVC in multiple pods and read/write simultaneously.

Which issue(s) this PR fixes:
Allow for first initial release #4

Special notes for your reviewer:
Patience, my dear Watson 🕵️‍♂️

Does this PR introduce a user-facing change?:

"NONE"

fyi: @msau42, @tombarron

[wozniakjan]

currently have this deployed in Kind, without visible errors:

csi-nodeplugin-nfsplugin container node-driver-registrar

$ k logs csi-nodeplugin-nfsplugin-hsg5d -c node-driver-registrar
I0228 14:03:43.926283       1 main.go:108] Version: v1.0.2-rc1-0-g2edd7f10
I0228 14:03:43.926372       1 main.go:115] Attempting to open a gRPC connection with: "/plugin/csi.sock"
I0228 14:03:43.926383       1 connection.go:69] Connecting to /plugin/csi.sock
I0228 14:03:43.926762       1 connection.go:96] Still trying, connection is CONNECTING
I0228 14:03:43.927195       1 connection.go:96] Still trying, connection is TRANSIENT_FAILURE
I0228 14:03:44.927608       1 connection.go:96] Still trying, connection is CONNECTING
I0228 14:03:44.927961       1 connection.go:93] Connected
I0228 14:03:44.927984       1 main.go:123] Calling CSI driver to discover driver name.
I0228 14:03:44.928219       1 connection.go:137] GRPC call: /csi.v1.Identity/GetPluginInfo
I0228 14:03:44.928237       1 connection.go:138] GRPC request: {}
I0228 14:03:44.930421       1 connection.go:140] GRPC response: {"name":"csi-nfsplugin","vendor_version":"1.0.0-rc2"}
I0228 14:03:44.931186       1 connection.go:141] GRPC error: <nil>
I0228 14:03:44.931195       1 main.go:131] CSI driver name: "csi-nfsplugin"
I0228 14:03:44.931217       1 node_register.go:54] Starting Registration Server at: /registration/csi-nfsplugin-reg.sock
I0228 14:03:44.931330       1 node_register.go:61] Registration Server started at: /registration/csi-nfsplugin-reg.sock
I0228 14:03:45.239857       1 main.go:76] Received GetInfo call: &InfoRequest{}
I0228 14:03:45.783321       1 main.go:76] Received GetInfo call: &InfoRequest{}
I0228 14:03:45.804562       1 main.go:86] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}

csi-nodeplugin-nfsplugin container nfs

$ k logs csi-nodeplugin-nfsplugin-hsg5d -c nfs
I0228 14:03:44.034095       1 nfs.go:47] Driver: csi-nfsplugin version: 1.0.0-rc2
I0228 14:03:44.034178       1 nfs.go:87] Enabling volume access mode: MULTI_NODE_MULTI_WRITER
I0228 14:03:44.034189       1 nfs.go:98] Enabling controller service capability: UNKNOWN
I0228 14:03:44.035940       1 server.go:92] Listening for connections on address: &net.UnixAddr{Name:"/plugin/csi.sock", Net:"unix"}

csi-attacher-nfsplugin container csi-attacher

$ k logs csi-attacher-nfsplugin-0 -c csi-attacher
I0228 14:03:38.022661       1 main.go:76] Version: v1.0.1-0-gb7dadac
I0228 14:03:38.023747       1 connection.go:89] Connecting to /csi/csi.sock
I0228 14:03:38.024042       1 connection.go:116] Still trying, connection is CONNECTING
I0228 14:03:38.024209       1 connection.go:116] Still trying, connection is TRANSIENT_FAILURE
I0228 14:03:39.024702       1 connection.go:116] Still trying, connection is CONNECTING
I0228 14:03:39.024943       1 connection.go:113] Connected
I0228 14:03:39.025006       1 connection.go:242] GRPC call: /csi.v1.Identity/Probe
I0228 14:03:39.025032       1 connection.go:243] GRPC request: {}
I0228 14:03:39.031296       1 connection.go:245] GRPC response: {}
I0228 14:03:39.031955       1 connection.go:246] GRPC error: <nil>
I0228 14:03:39.031965       1 main.go:211] Probe succeeded
I0228 14:03:39.031997       1 connection.go:242] GRPC call: /csi.v1.Identity/GetPluginInfo
I0228 14:03:39.032020       1 connection.go:243] GRPC request: {}
I0228 14:03:39.033069       1 connection.go:245] GRPC response: {"name":"csi-nfsplugin","vendor_version":"1.0.0-rc2"}
I0228 14:03:39.033602       1 connection.go:246] GRPC error: <nil>
I0228 14:03:39.033616       1 main.go:128] CSI driver name: "csi-nfsplugin"
I0228 14:03:39.033630       1 connection.go:242] GRPC call: /csi.v1.Identity/GetPluginCapabilities
I0228 14:03:39.033640       1 connection.go:243] GRPC request: {}
I0228 14:03:39.034664       1 connection.go:245] GRPC response: {"capabilities":[{"Type":{"Service":{"type":1}}}]}
I0228 14:03:39.035586       1 connection.go:246] GRPC error: <nil>
I0228 14:03:39.035594       1 connection.go:242] GRPC call: /csi.v1.Controller/ControllerGetCapabilities
I0228 14:03:39.035599       1 connection.go:243] GRPC request: {}
I0228 14:03:39.036564       1 connection.go:245] GRPC response: {"capabilities":[{"Type":{"Rpc":{}}}]}
I0228 14:03:39.037485       1 connection.go:246] GRPC error: <nil>
I0228 14:03:39.037497       1 main.go:155] CSI driver does not support ControllerPublishUnpublish, using trivial handler
I0228 14:03:39.037658       1 controller.go:111] Starting CSI attacher

csi-attacher-nfsplugin container nfs

$ k logs csi-attacher-nfsplugin-0 -c nfs
I0228 14:03:38.111549       1 nfs.go:47] Driver: csi-nfsplugin version: 1.0.0-rc2
I0228 14:03:38.111635       1 nfs.go:87] Enabling volume access mode: MULTI_NODE_MULTI_WRITER
I0228 14:03:38.111646       1 nfs.go:98] Enabling controller service capability: UNKNOWN
I0228 14:03:38.113266       1 server.go:92] Listening for connections on address: &net.UnixAddr{Name:"/plugin/csi.sock", Net:"unix"}

[wozniakjan]

https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

since 1.16, those apps/v1beta1 and v1beta2 are deprecated

[tombarron]

lgtm and tests out when exercised by manila-csi

[tombarron]

/assign msau42

[msau42]

We actually don't need attacher anymore starting in 1.14. We can set CSIDriver.attachRequired = false.

[wozniakjan]

perfect, thanks, removed the attacher and added CSIDriver in 50d5f44

and starting to have a tiny idea how does CSI work, finally :)

[tombarron]

Thanks, msau42!
With the latest commit this still checks out as I use it from manila-csi ...

[wozniakjan]

tested the CSI plugin and it seems to be working. The docs are also fairly accurate although I did take a bit of a detour using https://github.com/kubernetes-sigs/kind and https://github.com/rootfs/nfs-ganesha-docker. This might be worth appending to the docs at some point as alternative and less involved route for contributors to setup testing env.

From my perspective, this is ok to be released, what do you think @tombarron, @msau42 ?

[tombarron]

From my perspective, this is ok to be released, what do you think @tombarron, @msau42 ?

Seems good to me but @msau42 will know more :D

[wozniakjan]

also noticed this while glancing through the code. Probably worth at some point deriving this from git tag/sha in a similar fashion that kubectl does during build process?

[msau42]

the csi build tools does support injecting git tag into the version: https://github.com/kubernetes-csi/csi-release-tools/blob/master/build.make#L77

We just need to fix this up to use that. We can do that in a followup

[msau42]

/lgtm
/approve
Thanks so much!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment