Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: use vendor dir #113

Closed
wants to merge 10 commits into from
Closed

WIP: use vendor dir #113

wants to merge 10 commits into from

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 4, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR tests that we still use the vendor directory even when building with Go 1.13

Does this PR introduce a user-facing change?:

NONE

msau42 and others added 5 commits October 30, 2019 18:08
@msau42
Add new variables for 1.16 and remove 1.13
e0fde8c
@k8s-ci-robot
Merge pull request kubernetes-csi#40 from msau42/add-1.16
f419d74 
Add new variables for 1.16 and remove 1.13
@pohly
update CI to use Go 1.13.3
5e773d2 
This is the latest release. Updating is useful to ensure that we have
all of the latest fixes and enhancements.
@pohly
better handling of Go version
c8a1c4a 
Some operations are sensitive to the version of Go that is used. In
the past, formatting of source differed depending on the
version. Right now it is the content of the vendor directory which
changes when switch back and forth between 1.12 and 1.13.

We don't want to impose a certain workflow on developers, like forcing
all invocations of Go to run inside a container. If developers want
that, they can set up their development environment accordingly.

But we should warn about this aspect to raise awareness. "make"
invocations which involve Go now compare against the projects Go
version (specified in travis.yml) once at the beginning. This is only
a warning because we don't know which future version will be
compatible with the project.

Vendor directory handling gets updated, too: verification is now a
separate script (became too complex for make) and there is a
corresponding "update-vendor.sh". In contrast to verification,
updating vendor is not integrated into make and thus itself invokes
the go version check.
@k8s-ci-robot
Merge pull request kubernetes-csi#41 from pohly/go-version
a53bd4c 
Go version 1.13, helper scripts
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pohly
To complete the pull request process, please assign msau42
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@pohly pohly mentioned this pull request Nov 4, 2019
Merged
@pohly
Copy link
Contributor Author

pohly commented Nov 4, 2019

Replaced by #115

@pohly pohly closed this Nov 4, 2019
xing-yang added a commit to xing-yang/csi-driver-host-path that referenced this pull request Nov 19, 2020
@xing-yang
Squashed 'release-tools/' changes from 5d874cc..c6a88c6
54ce7b2 
c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller
45ec4c6 Fix the install of snapshot CRDs and controller

git-subtree-dir: release-tools
git-subtree-split: c6a88c6
@xing-yang xing-yang mentioned this pull request Nov 19, 2020
Merged
fengzixu pushed a commit to fengzixu/csi-driver-host-path that referenced this pull request Dec 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot…
c6a88c6 
…_controller

Fix the install of snapshot CRDs and controller
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 15, 2021
@pohly
Squashed 'release-tools/' changes from 7bc70e5..00bc64a9
3c0f612 
00bc64a9 remove travis.yml, Go 1.16
REVERT: 7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation
REVERT: e0b02e7 README.md: document usage of --squash
REVERT: 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate
REVERT: 26e2ab1 fix: default boilerplate path
REVERT: 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag
REVERT: 3e811d6 prow.sh: fix "on-master" prow jobs
REVERT: 1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag
REVERT: 9f10459 prow.sh: support building Kubernetes for a specific version
REVERT: fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
REVERT: 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master
REVERT: 1c94220 fix: fix a bug of csi-sanity
REVERT: a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
REVERT: ece0f50 check namespace for snapshot-controller
REVERT: dbd8967 verify-boilerplate.sh: fix path to script
REVERT: 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
REVERT: ad29307 Make the spelling and boilerplate checks optional
REVERT: 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
REVERT: 48186eb Fix spelling and boilerplate errors
REVERT: 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
REVERT: 981be3f Adding spelling and boilerplate checks.
REVERT: 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
REVERT: 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
REVERT: 9318c6c cloud build: double the timeout, now 1 hour
REVERT: 4ab8b15 use the tag to replace commit of csi-test
REVERT: 5d74e45 change the csi-test import path to v4
REVERT: 7dcd0a9 upgrade csi-test to v4.0.2
REVERT: 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
REVERT: c3a9662 allow export image name and registry name
REVERT: c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller
REVERT: 45ec4c6 Fix the install of snapshot CRDs and controller
REVERT: 5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup
REVERT: 79bbca7 Cleanup
REVERT: d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc
REVERT: 57718f8 Update snapshot CRD version
REVERT: 4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults
REVERT: 0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround
REVERT: 9a370ab prow.sh: work around "kind build node-image" failure
REVERT: 522361e prow.sh: only run alpha tests for latest Kubernetes release
REVERT: 22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master
REVERT: b5b447b Add go ldflags using LDFLAGS at the time of compilation
REVERT: 16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update

git-subtree-dir: release-tools
git-subtree-split: 00bc64a9b7c2585676b1da301a7acae8797229a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @k8s-ci-robot @msau42