split cloud_auth into gcp and azure

[mansona]

This PR is to track work on #700

This is probably going to be very WIP for a long time because I don't really know what I'm doing with this repo 😂 Please be as harsh as possible and tell me what I need to change to move forward 🙇

[k8s-ci-robot]

Welcome @mansona!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mansona]

I've signed the CLA

[brendandburns]

@mansona this looks totally reasonable. Please use the tests from config_test.ts instead of the ones from oidc as mentioned in the issue you filled and I think that this is good to merge.

[mansona]

@brendanburns I pulled the config tests that you mentioned but I only applied them to the azure file since they were all azure. Do you want me to duplicate them for gcp too?

[brendanburns]

Probably worth duplicating them since we're cloning the code. It will help prevent regressions. The only reason that they're only azure is because most of the code was shared.

…

On Tue, Jul 27, 2021, 1:51 PM Chris Manson ***@***.***> wrote: @brendanburns <https://github.com/brendanburns> I pulled the config tests that you mentioned but I only applied them to the azure file since they were all azure. Do you want me to duplicate them for gcp too? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#702 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJZQXUSVE7IO7DLIPAN64TTZ4L4LANCNFSM5AXNNE6A> .

[mansona]

I have added the tests for GCP now too 👍

Would you mind approving the workflows on this? I had a strange test failure on my local machine that I can't explain and I want to know if it's something in my environment or if it's something that I've broken 🙈

[brendandburns]

/lgtm
/approve

[brendandburns]

Looks like ci/cd is failing....

[mansona]

that's actually perfect! it's failing with the same error that I got locally so I know it's not my environment 🎉

I'll take a look and get this fixed in a bit 👍

[mansona]

I found the issue 🎉 there was a test that depended on the exact order and length of the authenticators in config instead of searching for the right one.

I fixed that: https://github.com/kubernetes-client/javascript/pull/702/files#diff-f7d16ccc3d41b45b1511b3e65724c67009d49174a7a290c4034487e89e13141dL1001-R752

[brendandburns]

/lgtm
/approve

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, mansona

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment