[feature request] Support GOOGLE_APPLICATION_CREDENTIALS

[mansona]

In #623 (comment) you mention that The current GCP authentication doesn't support that environment variable (GOOGLE_APPLICATION_CREDENTIALS) and that you wouldn't mind a PR.

I'm opening this PR to keep track of the feature request and maybe to open up the discussion on how to achieve this. I'm happy to take a crack at it but I really don't have a clue where to start and would love a few pointers 👍

[brendandburns]

The current GCP auth is here:

https://github.com/kubernetes-client/javascript/blob/master/src/cloud_auth.ts#L21

The right thing to do is probably to break GCP out into it's own file (that authenticator supports both Azure and GCP currently) and create a gcp_auth.ts update the registrations, etc.

Then you will need to figure out the right implementation of the authenticator interface.

[mansona]

So I did a minimal amount of work on this yesterday just to check to see if you were happy with the direction. I noticed that there weren't any tests for the cloudauth class so I copied some of the basic tests from oicd_auth_test.ts to at least get this process started.

I could do with some guidance on the testing front, even just giving me some pointers on things to test. I am not all that familiar with k8s authentication methods so I don't know if the placeholder tests that I copied from oicd_auth_test.ts apply to either GCP or Azure 🤔

[brendandburns]

There are a bunch of tests for the cloud provider in config_test.ts for historic reasons
e.g. https://github.com/kubernetes-client/javascript/blob/master/src/config_test.ts#L622

If you split out all of the tests with 'azure' in them into gcp/azue_test.ts and take them out of config_test.ts that's probably the best bet.

Thanks!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.