Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix cleanup logic for IAM policy bindings (#566)" #568

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jan 21, 2020

This reverts commit 4ebe571.

The list of service accounts only includes service accounts owned by the
project. So we ended up deleting bindings for service accounts owned by
other projects such as the service accounts.

related to: #566


This change is Reviewable

This reverts commit 4ebe571.

The list of service accounts only includes service accounts owned by the
project. So we ended up deleting bindings for service accounts owned by
other projects such as the service accounts.

related to: kubeflow#566
@jlewi
Copy link
Contributor Author

jlewi commented Jan 21, 2020

/assign @kunmingg

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jlewi
You can assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@jlewi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-testing-presubmit f163829 link /test kubeflow-testing-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kunmingg
Copy link
Contributor

/lgtm

@jlewi
Copy link
Contributor Author

jlewi commented Jan 21, 2020

Force merging because tests are broken right now because of this.

@jlewi jlewi merged commit b58ed35 into kubeflow:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants