Fix cleanup logic for IAM policy bindings #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We are not properly GC'ing policy bindings for deleted service accounts. * The problem is that we only consider service accounts matching a certain regex and that regex isn't matching service accounts for our auto-deployed clusters. * Using a regex should be unnecessary. If a service account doesn't exist that should be a sufficient criterion that the policy bindings should be deleted. Related to: kubeflow#543
|
/assign @richardsliu |
|
Here are the logs from a one off run. It looks like a bunch of old bindings were GC'd. Here's the current policy. kubeflow.ci.deployment.policy.txt Looks like a bunch of bindings were pruned. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jan 21, 2020
This reverts commit 4ebe571. The list of service accounts only includes service accounts owned by the project. So we ended up deleting bindings for service accounts owned by other projects such as the service accounts. related to: kubeflow#566
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jan 22, 2020
…)"" This reverts commit f163829.
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jan 22, 2020
* We want to cleanup bindings for service accounts that don't exist
as a way to GC any bindings that might otherwise accumulate.
* However, we only want to GC bindings for service accounts that are
owned by that project because only those service accounts will be listed
as service accounts for that project
e.g. in the project kubeflow-ci-deployment; we should only delete bindings
for the service accounts
${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com
Any other bindings should be preserved.
* related to: kubeflow#566
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jan 22, 2020
* We want to cleanup bindings for service accounts that don't exist
as a way to GC any bindings that might otherwise accumulate.
* However, we only want to GC bindings for service accounts that are
owned by that project because only those service accounts will be listed
as service accounts for that project
e.g. in the project kubeflow-ci-deployment; we should only delete bindings
for the service accounts
${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com
Any other bindings should be preserved.
* related to: kubeflow#566
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Jan 22, 2020
* We want to cleanup bindings for service accounts that don't exist
as a way to GC any bindings that might otherwise accumulate.
* However, we only want to GC bindings for service accounts that are
owned by that project because only those service accounts will be listed
as service accounts for that project
e.g. in the project kubeflow-ci-deployment; we should only delete bindings
for the service accounts
${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com
Any other bindings should be preserved.
* related to: kubeflow#566
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jan 24, 2020
* Fix cleanup logic for IAM policy bindings.
* We want to cleanup bindings for service accounts that don't exist
as a way to GC any bindings that might otherwise accumulate.
* However, we only want to GC bindings for service accounts that are
owned by that project because only those service accounts will be listed
as service accounts for that project
e.g. in the project kubeflow-ci-deployment; we should only delete bindings
for the service accounts
${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com
Any other bindings should be preserved.
* related to: #566
* Cleanup.
* Add dryrun logging.
* Update PR.
* Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not properly GC'ing policy bindings for deleted service accounts.
The problem is that we only consider service accounts matching a certain
regex and that regex isn't matching service accounts for our auto-deployed
clusters.
Using a regex should be unnecessary. If a service account doesn't exist
that should be a sufficient criterion that the policy bindings should be
deleted.
Related to: #543
This change is