-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): bump argo-workflows to latest. #6920
chore(backend): bump argo-workflows to latest. #6920
Conversation
Hi @jmcarp. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you also update https://github.com/kubeflow/pipelines/tree/master/manifests as well? Examples: a89183f#diff-75d17c1c8ea73190533f46fa0bfb393085b8f96b0587c51622e8f9388fd23477 |
/ok-to-test |
I realized that this step will need to be done by me. I will do this step. |
@jmcarp Would you mind granting me edit permission to your branch? https://github.com/jmcarp/pipelines/tree/jmcarp/argo-workflows-v3.2 So I can push images based on your change. |
@zijianjoy let me know if I need to do anything else you give you access to my branch. |
/retest-required I have pushed the license compliance images. |
/retest-required |
Question: Why do we need to upgrade golang version for presubmit in this PR? |
5a458fd
to
f229326
Compare
Creating PR to supplement your argo workflow change: jmcarp#1. I was not able to directly push to your branch since the name has changed to |
Update cloud.build and manifests to argo v3.2.3
/lgtm Thank you for your PR! |
/assign @Bobgy |
Hi @Bobgy, would it be possible to get this into the 1.8 release? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Bump argo-workflows to latest. * Bump presubmit golang version. * Pull latest image tags. * Update cloud.build and manifests to argo v3.2.3 Co-authored-by: James Liu <[email protected]>
Description of your changes:
Try to upgrade argo-workflows based on previous PRs. Resolves #6916.
Checklist: