Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): bump argo-workflows to latest. #6920

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Nov 17, 2021

Description of your changes:

Try to upgrade argo-workflows based on previous PRs. Resolves #6916.

Checklist:

@google-oss-prow
Copy link

Hi @jmcarp. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zijianjoy
Copy link
Collaborator

@zijianjoy
Copy link
Collaborator

/ok-to-test

@zijianjoy
Copy link
Collaborator

zijianjoy commented Nov 19, 2021

You will need to update .cloudbuild.yaml and .release.cloudbuild.yaml as well: a89183f#diff-51ad04b116a62f170e26dd77721528424f95fbc1df7adcd2a325bdaa100dac08

I realized that this step will need to be done by me. I will do this step.

@zijianjoy
Copy link
Collaborator

@jmcarp Would you mind granting me edit permission to your branch? https://github.com/jmcarp/pipelines/tree/jmcarp/argo-workflows-v3.2 So I can push images based on your change.

@jmcarp
Copy link
Contributor Author

jmcarp commented Nov 20, 2021

Do you not have access to my fork? Maintainers should be allowed to push:

Screen Shot 2021-11-19 at 7 32 55 PM

And I invited you to my fork:

Screen Shot 2021-11-19 at 7 33 08 PM

@jmcarp
Copy link
Contributor Author

jmcarp commented Nov 24, 2021

@zijianjoy let me know if I need to do anything else you give you access to my branch.

@zijianjoy
Copy link
Collaborator

/retest-required

I have pushed the license compliance images.

@jmcarp
Copy link
Contributor Author

jmcarp commented Nov 24, 2021

/retest-required

@zijianjoy
Copy link
Collaborator

Question: Why do we need to upgrade golang version for presubmit in this PR?

@jmcarp jmcarp force-pushed the jmcarp/argo-workflows-v3.2 branch from 5a458fd to f229326 Compare November 24, 2021 23:19
@zijianjoy
Copy link
Collaborator

zijianjoy commented Nov 25, 2021

Creating PR to supplement your argo workflow change: jmcarp#1.

I was not able to directly push to your branch since the name has changed to jmcarp/argo-workflows-v3.2 (I guess having slash / in the branch name is a bit tricky to push commits to this remote branch, maybe it is conflicting with the repository name)

Update cloud.build and manifests to argo v3.2.3
@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you for your PR!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 25, 2021
@zijianjoy
Copy link
Collaborator

/assign @Bobgy

@jmcarp
Copy link
Contributor Author

jmcarp commented Dec 1, 2021

Hi @Bobgy, would it be possible to get this into the 1.8 release?

@Bobgy
Copy link
Contributor

Bobgy commented Dec 1, 2021

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 25dfe60 into kubeflow:master Dec 1, 2021
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
* Bump argo-workflows to latest.

* Bump presubmit golang version.

* Pull latest image tags.

* Update cloud.build and manifests to argo v3.2.3

Co-authored-by: James Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Upgrade argo-workflows to 3.2.x
3 participants