Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release script for component images #570

Closed
wants to merge 11 commits into from

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Dec 19, 2018

This resolve the double release issue. Pleases see the comment in release.sh for how to run the script.

Running the script require you have write access to gcr.io/ml-pipeline


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ironpan

If they are not already assigned, you can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan closed this Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

@IronPan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 13e3479 link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Fix cleanup logic for IAM policy bindings.

* We want to cleanup bindings for service accounts that don't exist
  as a way to GC any bindings that might otherwise accumulate.

* However, we only want to GC bindings for service accounts that are
  owned by that project because only those service accounts will be listed
  as service accounts for that project

  e.g. in the project kubeflow-ci-deployment; we should only delete bindings
  for the service accounts
  ${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com

  Any other bindings should be preserved.

* related to: kubeflow#566

* Cleanup.

* Add dryrun logging.

* Update PR.

* Fix lint.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants