-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release script for component images #570
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@IronPan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Fix cleanup logic for IAM policy bindings. * We want to cleanup bindings for service accounts that don't exist as a way to GC any bindings that might otherwise accumulate. * However, we only want to GC bindings for service accounts that are owned by that project because only those service accounts will be listed as service accounts for that project e.g. in the project kubeflow-ci-deployment; we should only delete bindings for the service accounts ${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com Any other bindings should be preserved. * related to: kubeflow#566 * Cleanup. * Add dryrun logging. * Update PR. * Fix lint.
This resolve the double release issue. Pleases see the comment in release.sh for how to run the script.
Running the script require you have write access to gcr.io/ml-pipeline
This change is