Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samples for volumes mount in containerop #566

Closed
gaoning777 opened this issue Dec 19, 2018 · 5 comments
Closed

Add samples for volumes mount in containerop #566

gaoning777 opened this issue Dec 19, 2018 · 5 comments

Comments

@gaoning777
Copy link
Contributor

As the DSL support VolumeMount in containerop, it would be best to have samples illustrating how to use it.

@gaoning777 gaoning777 changed the title Add samples for volumes mount Add samples for volumes mount in containerop Dec 19, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 20, 2018

All our samples use volume mounting indirectly through the use_gcp_secret call.
Unless we have customers that have some other need for volume mounting by the user, I'm not sure we need to emphasize volumes.

@gaoning777
Copy link
Contributor Author

I have been asked by customers and Sina about how to set up the volumes in the DSL. The use_gcp_secret is not straighforward to the users about how to use the volumes.

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

@gaoning777, I am assigning the DSL sample issues to illustrate features to you. Please reassign to the most appropriate person as needed.

@gaoning777
Copy link
Contributor Author

@elikatsis
Copy link
Member

Minor Update:

I opened #1433 to better organize these examples and also provide a mini documentation.

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
* Fix cleanup logic for IAM policy bindings

* We are not properly GC'ing policy bindings for deleted service accounts.

* The problem is that we only consider service accounts matching a certain
  regex and that regex isn't matching service accounts for our auto-deployed
  clusters.

* Using a regex should be unnecessary. If a service account doesn't exist
  that should be a sufficient criterion that the policy bindings should be
  deleted.

Related to: kubeflow/testing#543

* Fix typo.

* Fix syntax issue.
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
…beflow#568)

This reverts commit 4ebe571.

The list of service accounts only includes service accounts owned by the
project. So we ended up deleting bindings for service accounts owned by
other projects such as the service accounts.

related to: kubeflow#566
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
* Fix cleanup logic for IAM policy bindings.

* We want to cleanup bindings for service accounts that don't exist
  as a way to GC any bindings that might otherwise accumulate.

* However, we only want to GC bindings for service accounts that are
  owned by that project because only those service accounts will be listed
  as service accounts for that project

  e.g. in the project kubeflow-ci-deployment; we should only delete bindings
  for the service accounts
  ${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com

  Any other bindings should be preserved.

* related to: kubeflow#566

* Cleanup.

* Add dryrun logging.

* Update PR.

* Fix lint.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
* Regenerate E2E test logs for release 0.8.0

* Regerate "golden" log files

* Regenerate "golden" logs after PR kubeflow#567

* Update list of ignored tests

* Add cond_recur.yaml to list of ignored tests

* Regenerate E2E logs after updating "golden" YAML files of unit tests

* Regenerate E2E logs after enabling auto-strip EOF

* Regenerate "golden" YAML for unit tests

* Rename loop-static CRDs

* Regenerate E2E logs, enable EOF stripping only for E2E test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants