-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add samples for volumes mount in containerop #566
Comments
All our samples use volume mounting indirectly through the use_gcp_secret call. |
I have been asked by customers and Sina about how to set up the volumes in the DSL. The use_gcp_secret is not straighforward to the users about how to use the volumes. |
@gaoning777, I am assigning the DSL sample issues to illustrate features to you. Please reassign to the most appropriate person as needed. |
VolumeOp is illustrated here: https://github.com/kubeflow/pipelines/tree/master/samples/resourceops |
Minor Update: I opened #1433 to better organize these examples and also provide a mini documentation. |
* Fix cleanup logic for IAM policy bindings * We are not properly GC'ing policy bindings for deleted service accounts. * The problem is that we only consider service accounts matching a certain regex and that regex isn't matching service accounts for our auto-deployed clusters. * Using a regex should be unnecessary. If a service account doesn't exist that should be a sufficient criterion that the policy bindings should be deleted. Related to: kubeflow/testing#543 * Fix typo. * Fix syntax issue.
…beflow#568) This reverts commit 4ebe571. The list of service accounts only includes service accounts owned by the project. So we ended up deleting bindings for service accounts owned by other projects such as the service accounts. related to: kubeflow#566
* Fix cleanup logic for IAM policy bindings. * We want to cleanup bindings for service accounts that don't exist as a way to GC any bindings that might otherwise accumulate. * However, we only want to GC bindings for service accounts that are owned by that project because only those service accounts will be listed as service accounts for that project e.g. in the project kubeflow-ci-deployment; we should only delete bindings for the service accounts ${NAME}@kubeflow-ci-deployment.iam.gserviceaccount.com Any other bindings should be preserved. * related to: kubeflow#566 * Cleanup. * Add dryrun logging. * Update PR. * Fix lint.
* Regenerate E2E test logs for release 0.8.0 * Regerate "golden" log files * Regenerate "golden" logs after PR kubeflow#567 * Update list of ignored tests * Add cond_recur.yaml to list of ignored tests * Regenerate E2E logs after updating "golden" YAML files of unit tests * Regenerate E2E logs after enabling auto-strip EOF * Regenerate "golden" YAML for unit tests * Rename loop-static CRDs * Regenerate E2E logs, enable EOF stripping only for E2E test
As the DSL support VolumeMount in containerop, it would be best to have samples illustrating how to use it.
The text was updated successfully, but these errors were encountered: