build(components): buildCpuTrainer failure #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the archive page
…page and the archive page" This reverts commit 5b67273.
|
This change is |
|
/test kubeflow-pipeline-e2e-test |
Bobgy
reviewed
Aug 24, 2020
| @@ -19,7 +19,7 @@ while getopts ":hp:t:i:b:l:" opt; do | |||
| echo "-t: tag name" | |||
| echo "-i: image name. If provided, project name and tag name are not necessary" | |||
| echo "-b: tensorflow base image tag. Optional. The value can be tags listed under \ | |||
| https://hub.docker.com/r/tensorflow/tensorflow/tags. Defaults to '1.6.0'." | |||
| https://hub.docker.com/r/tensorflow/tensorflow/tags. Defaults to '2.3.0'." | |||
There was a problem hiding this comment.
tensorflow is 2.3.0, while tensorflow transform and tensorflow model analysis is 0.23.0
Bobgy
changed the title
Ark-kun
reviewed
Aug 24, 2020
| @@ -53,7 +53,7 @@ if [ -z "${TAG_NAME}" ]; then | |||
| fi | |||
|
|
|||
| if [ -z "${TF_BASE_TAG}" ]; then | |||
| TF_BASE_TAG=1.6.0 | |||
| TF_BASE_TAG=0.23.0 | |||
There was a problem hiding this comment.
Thank you for catching this. Revised.
|
Thank you for taking on this issue, Jing. |
|
/lgtm |
|
/test kubeflow-pipeline-backend-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jingzhang36 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Bobgy
added
the
cherrypick-approved
Bobgy
pushed a commit
to Bobgy/pipelines
that referenced
this pull request
Sep 4, 2020
* enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * fix buildcputrainer error * update args when calling build image shell script * remove tmp test file * tensorflow is 2.3.0 * remove accidently checked in file
Bobgy
pushed a commit
to Bobgy/pipelines
that referenced
this pull request
Sep 4, 2020
* enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * fix buildcputrainer error * update args when calling build image shell script * remove tmp test file * tensorflow is 2.3.0 * remove accidently checked in file
Bobgy
pushed a commit
that referenced
this pull request
Sep 4, 2020
* enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * fix buildcputrainer error * update args when calling build image shell script * remove tmp test file * tensorflow is 2.3.0 * remove accidently checked in file
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * fix buildcputrainer error * update args when calling build image shell script * remove tmp test file * tensorflow is 2.3.0 * remove accidently checked in file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
We've observed persistent errors in buildCpuTrainer and buildGpuTrainer which seem to be caused by a version issue with setuptools. However, since we use tensorflow image 1.6.0, the latest setuptools via apt-get is 20.7.0. Therefore, in order to increase setuptools version, we increase tensorflow image to 2.3.0 and as a result, tensorflow transform and tensorflow model analysis need to be increased too. Let's see if this can get rid of the error.
Part of #4361
Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
fix(frontend): fixes empty page. Fixes #1234Use
fixto indicate that this PR fixes a bug.feat(backend): configurable service account. Fixes #1234, fixes #1235Use
featto indicate that this PR adds a new feature.chore: set up changelog generation toolsUse
choreto indicate that this PR makes some changes that users don't need to know.test: fix CI failure. Part of #1234Use
part ofto indicate that a PR is working on an issue, but shouldn't close the issue when merged.Do you want this pull request (PR) cherry-picked into the current release branch?
If yes, use one of the following options:
cherrypick-approvedlabel to this PR. The release manager adds this PR to the release branch in a batch update.