Skip to content

Commit

Permalink
build(components): buildCpuTrainer failure (kubeflow#4405)
Browse files Browse the repository at this point in the history
* enable pagination when expanding experiment in both the home page and the archive page

* Revert "enable pagination when expanding experiment in both the home page and the archive page"

This reverts commit 5b67273.

* fix buildcputrainer error

* update args when calling build image shell script

* remove tmp test file

* tensorflow is 2.3.0

* remove accidently checked in file
  • Loading branch information
jingzhang36 authored and Bobgy committed Sep 4, 2020
1 parent 2e9ae98 commit 47a9fd7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,11 @@ steps:
- id: 'buildCpuTrainer'
name: 'gcr.io/cloud-builders/docker'
entrypoint: '/bin/bash'
args: ['-c', 'cd /workspace/components/kubeflow/dnntrainer && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA -l ml-pipeline-kubeflow-tf-trainer -b 1.6.0']
args: ['-c', 'cd /workspace/components/kubeflow/dnntrainer && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA -l ml-pipeline-kubeflow-tf-trainer -b 2.3.0']
waitFor: ["-"]
- name: 'gcr.io/cloud-builders/docker'
entrypoint: '/bin/bash'
args: ['-c', 'cd /workspace/components/kubeflow/dnntrainer && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA -l ml-pipeline-kubeflow-tf-trainer-gpu -b 1.6.0-gpu']
args: ['-c', 'cd /workspace/components/kubeflow/dnntrainer && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA -l ml-pipeline-kubeflow-tf-trainer-gpu -b 2.3.0-gpu']
id: 'buildGpuTrainer'
waitFor: ["-"]

Expand Down Expand Up @@ -238,7 +238,7 @@ steps:
# Tag for Hosted - Tag to hosted folder with MKP friendly name
- id: 'tagForHosted'
waitFor: ['parseMajorMinorVersion', 'buildFrontend', 'buildApiServer', 'buildScheduledWorkflow',
waitFor: ['parseMajorMinorVersion', 'buildFrontend', 'buildApiServer', 'buildScheduledWorkflow',
'buildViewerCrdController', 'buildPersistenceAgent', 'buildInverseProxyAgent', 'buildVisualizationServer',
'buildMetadataWriter', 'buildCacheServer', 'buildCacheDeployer', 'buildMetadataEnvoy',
'buildMarketplaceDeployer', 'pullMetadataServer', 'pullMinio', 'pullMysql', 'pullCloudsqlProxy',
Expand Down
4 changes: 2 additions & 2 deletions components/kubeflow/dnntrainer/build_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ while getopts ":hp:t:i:b:l:" opt; do
echo "-t: tag name"
echo "-i: image name. If provided, project name and tag name are not necessary"
echo "-b: tensorflow base image tag. Optional. The value can be tags listed under \
https://hub.docker.com/r/tensorflow/tensorflow/tags. Defaults to '1.6.0'."
https://hub.docker.com/r/tensorflow/tensorflow/tags. Defaults to '2.3.0'."
echo "-l: local image name. Optional. Defaults to 'ml-pipeline-kubeflow-tf-trainer'"
exit
;;
Expand Down Expand Up @@ -53,7 +53,7 @@ if [ -z "${TAG_NAME}" ]; then
fi

if [ -z "${TF_BASE_TAG}" ]; then
TF_BASE_TAG=1.6.0
TF_BASE_TAG=2.3.0
fi

mkdir -p ./build
Expand Down

0 comments on commit 47a9fd7

Please sign in to comment.