rename list experiment -> list experiments #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronPan
requested review from
pineking,
qimingj and
rileyjbauer
and removed request for
yebrahim,
vicaire and
pineking
|
Let's please wait until after Beta due to downstream impact. |
vicaire
suggested changes
Nov 9, 2018
| @@ -461,9 +461,6 @@ | |||
| "$ref": "#/definitions/apiRunMetric" | |||
| }, | |||
| "description": "Output. The metrics of the run. The metrics are reported by ReportMetrics\nAPI." | |||
There was a problem hiding this comment.
The unit tests for the experiment client wrapper will fail with this change. They need to be updated.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@IronPan: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@IronPan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@IronPan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Updates for vendor and fix rbac issue * Add a development kustomize overlay * revery dep ensure * revert Gopkg.lock
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Change e2e test job to point to kserve repo * Fix prow config * Remove dir dep * fix image-transformer built image tag (kubeflow#44) * fix image-transformer built image tag Signed-off-by: Theofilos Papapanagiotou <[email protected]> * rename ecr registry directory for kserve Signed-off-by: Theofilos Papapanagiotou <[email protected]> * merging kserve branch to master (kubeflow#35) * KServe Go module and API group change -------------------------------------- Updated go source files with new go module. Changed apigroup in yaml files. Made changes in Makefile to represent the repository and apigroup names. Verified `make test` is passing. Removed reference for old names. * Pointed correct repo reference for ko images (kubeflow#23) * Rename changes python - New (kubeflow#19) * python changes-initial-commit * updated api gen. Renamed package references in python. * Renamed python/kfserving to python/kserve * renamed python folder according to package kserve * Ran client-gen. Updated swagger.json * renamed constants from KFSERVING_ to KSERVE_. Yet to change namespace from kfserving-system to kserve and hence not changed in python side. * Updated kfserving reference to kserve Updated version for Python Package Index to 0.7.0rc0 Renamed KFServingSampleModel to KServeSampleModel * Python package and corresponding directory change has to be reflected in test and dockerfiles * updated a specific version in requirments to address issue with pip resolver. Added more specific versions in requirements,txt and updated paddleserver setup.py with kserve dependency. * Changed namespace from kfserving-system to kserve (kubeflow#31) * Update local dev scripts (kubeflow#33) * initial commit of dev-scripts update * Updated quick-install * Updated python Makefile * Generated install for new release * Updated generate-install script with new release * Reverting controller name in makefile. Will be updated in separate pr. * Github action changes (kubeflow#34) * Github action changes Migrated images publish to kserve repo. Added github workflows for the ones that was being pushed to gcr.io from release/triggers. * Removed batcher publisher since batcher.Dockerfile does not exist Updated tf2openapi.Dockerfile to correct directory and package. * Fixed issue with working directory of tf2openapi workflow * Removed the deptrecated logger docker * Excluded tests from linting. (kubeflow#36) They were pointing to older directory and package names and hence were not being excluded while linting. * Update license (kubeflow#20) * Fixed errors thrown by flake8 linter (kubeflow#37) * Kfserving kserve manifests changes and code reference changes (kubeflow#39) * kfserving -> kserve migartion initial commit * kfserving -> kserve config changes * Changed constants. Updated image reference from kserve to andyarok * Reverted kserve models web app image repo. * go changes for kfserving-kserve * Updated KFServing refernce in python code * Updated KFServing to KServe in python doc comments. Updated references of v1alpha2 from duplicate aliases to just use pkg name. Updated docs samples references with proper name. Made changes to use Constant for container name instead of literal "kserve-container". * Updated gitignore for generated files that came in after folder rename. Removed the generated files. Fixed lint warnings for go. * Removed travis yml file. * KServe doc update (kubeflow#38) * Update main and pythonserver readme * Update python docs * Fix role binding * Update kserve sdk doc * Fix e2e test script * Fix import * Kserve error fix (kubeflow#40) * Fixed linting errors in python * Fixed make test. Issue with storage initializer name/path. * Fixed failing python test. Updated ray version. Updated KFServingClient reference to KServeClient in kserve init. * Updated ray version from 1.4.0 to 1.5.0 * Fixed error with e2e due to kfserving reference in test overlay (kubeflow#42) Updated quick install and added 0.7.0-rc0 install manifests. Updated e2e namespace. * Controller repo update (kubeflow#45) Made changes in workflow to update image repo to kserve instead of kfserving * Controller repo update (kubeflow#45) Made changes in workflow to update image repo to kserve instead of kfserving * update pytorch image * Fix transformer dockerfile Co-authored-by: Andrews Arokiam <[email protected]> Co-authored-by: andyi2it <[email protected]> * Generate 0.7.0 release candidate and update roadmap/release process (kubeflow#46) * Fix apiVersion for examples and docs (kubeflow#55) Fix apiVersion for examples and docs change from serving.kubeflow.org to serving.kserve.io * add default deployment and fix startup without knative to master branch (kubeflow#57) * add default deployment and fix startup without knative * fix suite_test error * fix suit_test error * add constant vb for RawDeployment and Serverless * update predictor string RawDeployment to constants.RawDeployment * modify getDeploymentMode return type * Update kserve layer diagram (kubeflow#58) * update diag (kubeflow#59) * Remove kubeflow copyright (kubeflow#56) * Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe" (kubeflow#60) * Delete kfs_architect.png * Add files via upload Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe" * Delete kfs_architect.png * Delete kfs_architect.drawio * added Metric scrapping title * Delete kfs_architect.png * Delete kfs_architect.drawio * fixed typo * add Nick Hill as a reviewer (kubeflow#66) also removing rkelkar * Separate out web-app repo (kubeflow#68) * Sepate out web-app repo * Remove models web-app github action * Fix feast example Co-authored-by: Theofilos Papapanagiotou <[email protected]> Co-authored-by: Andrews Arokiam <[email protected]> Co-authored-by: andyi2it <[email protected]> Co-authored-by: Chin Huang <[email protected]> Co-authored-by: Qingshan Chen <[email protected]> Co-authored-by: Animesh Singh <[email protected]> Co-authored-by: js-ts <[email protected]>
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
Update MySQL Image, add MariaDB overlay
HumairAK
referenced
this pull request
in HumairAK/data-science-pipelines
May 10, 2024
<UPSTREAM>: <carry>: Added OwnerReferences to ScheduledWorkflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is