Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to delete experiment. #60

Closed
Ark-kun opened this issue Nov 5, 2018 · 19 comments
Closed

Add the ability to delete experiment. #60

Ark-kun opened this issue Nov 5, 2018 · 19 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 5, 2018

No description provided.

@yebrahim
Copy link
Contributor

yebrahim commented Nov 6, 2018

This requires the backend API to be there. @IronPan to chime in, is there an issue tracking that work?

@amygdala
Copy link
Contributor

amygdala commented Nov 9, 2018

+1 to this being important.

@IronPan
Copy link
Member

IronPan commented Nov 9, 2018

API would provided as part of this #112

@yebrahim
Copy link
Contributor

yebrahim commented Nov 9, 2018

More context from @IronPan: That API orphans the deleted experiment's runs though, it doesn't delete them.
This is fine for now, but if we don't also offer a delete run API, the All runs view will be cluttered with all the orphaned runs.

@ajayalfred any thoughts here? What do you think of this as a starting point?

@ajayalfred
Copy link
Contributor

Since runs are organized inside experiments, a user would expect deleting an experiment to delete the runs contained as well. I don't see a usecase where the user will expect this to behave otherwise and produce orphaned runs.

A delete run API is still needed for the case when a user wants to delete an individual run/set of runs inside an experiment.

Does that make sense?

@yebrahim
Copy link
Contributor

Yup, that's what I'd prefer to do too.
So I guess we'll block this on support for deleting an experiment's runs from the backend.
cc/ @IronPan.

@animeshsingh
Copy link
Contributor

Ho folks - any progress on this one?

@yebrahim
Copy link
Contributor

I don't think we have anyone working on this, feel free to pick up the discussion if you feel like it.
There is however some work I'm doing now to support archiving runs, which should help declutter the workspace. Experiments are still create-only though.

@JohnPaton
Copy link
Contributor

JohnPaton commented Apr 17, 2019

+1 on this, in multi-user settings experiments will pile up quickly

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 25, 2019

+1 on this, in multi-user settings experiments will pile up quickly

The solution to this is probably a default filter that only shows your own experiments.

@yaronha
Copy link
Contributor

yaronha commented Jun 16, 2019

@Ark-kun maybe we should have labels based filter, people can add labels like owner, project,..

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 21, 2019

maybe we should have labels based filter, people can add labels like owner, project,..

I like this approach.

@wcass77
Copy link

wcass77 commented Jun 21, 2019

What if instead of deleting, we just had an option to archive, like with runs. There should also be an option to archive pipelines. That way no metadata is lost, but old experiments are out of the way

Sent with GitHawk

@jessiezcc jessiezcc assigned jingzhang36 and unassigned IronPan Jul 17, 2019
@FaustineLi
Copy link

Why not allow archiving / deleting for experiments with no unarchived runs? Would be interested in this feature.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 4, 2019

no metadata is lost, but old experiments are out of the wa

Would showing the experiments with recent runs first solve your issues? #249

@FaustineLi
Copy link

no metadata is lost, but old experiments are out of the wa

Would showing the experiments with recent runs first solve your issues? #249

Probably. I just want to hide the experiments that aren't relevant to me. The filter ideally should only show experiments you create by default too (in the situation where multiple scientists are sharing a cluster).

@Bobgy
Copy link
Contributor

Bobgy commented Mar 16, 2020

Closing this as a duplicate of #1263
We plan to support archiving experiments in KFP 1.0

@Bobgy
Copy link
Contributor

Bobgy commented Mar 16, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Change e2e test job to point to kserve repo

* Fix prow config

* Remove dir dep

* fix image-transformer built image tag (kubeflow#44)

* fix image-transformer built image tag

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* rename ecr registry directory for kserve

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* merging kserve branch to master (kubeflow#35)

* KServe Go module and API group change
--------------------------------------

Updated go source files with new go module.
Changed apigroup in yaml files.
Made changes in Makefile to represent the repository and apigroup names.

Verified `make test` is passing.

Removed reference for old names.

* Pointed correct repo reference for ko images (kubeflow#23)

* Rename changes python - New (kubeflow#19)

* python changes-initial-commit

* updated api gen.
Renamed package references in python.

* Renamed python/kfserving to python/kserve

* renamed python folder according to package kserve

* Ran client-gen. Updated swagger.json

* renamed constants from KFSERVING_ to KSERVE_.
Yet to change namespace from kfserving-system to kserve and hence not changed in python side.

* Updated kfserving reference to kserve
Updated version for Python Package Index to 0.7.0rc0
Renamed KFServingSampleModel to KServeSampleModel

* Python package and corresponding directory change has to be reflected in test and dockerfiles

* updated a specific version in requirments to address issue with pip resolver.
Added more specific versions in requirements,txt and updated paddleserver setup.py with kserve dependency.

* Changed namespace from kfserving-system to kserve (kubeflow#31)

* Update local dev scripts (kubeflow#33)

* initial commit of dev-scripts update

* Updated quick-install

* Updated python Makefile

* Generated install for new release

* Updated generate-install script with new release

* Reverting controller name in makefile.
Will be updated in separate pr.

* Github action changes (kubeflow#34)

* Github action changes

Migrated images publish to kserve repo.
Added github workflows for the ones that was being pushed to gcr.io from release/triggers.

* Removed batcher publisher since batcher.Dockerfile does not exist
Updated tf2openapi.Dockerfile  to correct directory and package.

* Fixed issue with working directory of tf2openapi workflow

* Removed the deptrecated logger docker

* Excluded tests from linting. (kubeflow#36)

They were pointing to older directory and package names and
hence were not being excluded while linting.

* Update license (kubeflow#20)

* Fixed errors thrown by flake8 linter (kubeflow#37)

* Kfserving kserve manifests changes and code reference changes (kubeflow#39)

* kfserving -> kserve migartion initial commit

* kfserving -> kserve config changes

* Changed constants.
Updated image reference from kserve to andyarok

* Reverted kserve models web app  image repo.

* go changes for kfserving-kserve

* Updated KFServing refernce in python code

* Updated KFServing to KServe in python doc comments.
Updated references of v1alpha2 from duplicate aliases to just use pkg name.
Updated docs samples references with proper name.
Made changes to use Constant for container name instead of literal "kserve-container".

* Updated gitignore for generated files that came in after folder rename.
Removed the generated files.
Fixed lint warnings for go.

* Removed travis yml file.

* KServe doc update (kubeflow#38)

* Update main and pythonserver readme

* Update python docs

* Fix role binding

* Update kserve sdk doc

* Fix e2e test script

* Fix import

* Kserve error fix (kubeflow#40)

* Fixed linting errors in python

* Fixed make test.
Issue with storage initializer name/path.

* Fixed failing python test.
Updated ray version.
Updated KFServingClient reference to KServeClient in kserve init.

* Updated ray version from 1.4.0 to 1.5.0

* Fixed error with e2e due to kfserving reference in test overlay (kubeflow#42)

Updated quick install and added 0.7.0-rc0 install manifests.
Updated e2e namespace.

* Controller repo update (kubeflow#45)

Made changes in workflow to update image repo to kserve instead of kfserving

* Controller repo update (kubeflow#45)

Made changes in workflow to update image repo to kserve instead of kfserving

* update pytorch image

* Fix transformer dockerfile

Co-authored-by: Andrews Arokiam <[email protected]>
Co-authored-by: andyi2it <[email protected]>

* Generate 0.7.0 release candidate and update roadmap/release process (kubeflow#46)

* Fix apiVersion for examples and docs (kubeflow#55)

Fix apiVersion for examples and docs change from serving.kubeflow.org
to serving.kserve.io

* add default deployment and fix startup without knative to master branch (kubeflow#57)

* add default deployment and fix startup without knative

* fix suite_test error

* fix suit_test error

* add constant vb for RawDeployment and Serverless

* update predictor string RawDeployment to constants.RawDeployment

* modify getDeploymentMode return type

* Update kserve layer diagram (kubeflow#58)

* update diag (kubeflow#59)

* Remove kubeflow copyright (kubeflow#56)

* Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe" (kubeflow#60)

* Delete kfs_architect.png

* Add files via upload

Adding kfs_architect.drawio and changing kfs_architect.png's "KFserving" name to "KServe"

* Delete kfs_architect.png

* Delete kfs_architect.drawio

* added Metric scrapping title

* Delete kfs_architect.png

* Delete kfs_architect.drawio

* fixed typo

* add Nick Hill as a reviewer (kubeflow#66)

also removing rkelkar

* Separate out web-app repo (kubeflow#68)

* Sepate out web-app repo

* Remove models web-app github action

* Fix feast example

Co-authored-by: Theofilos Papapanagiotou <[email protected]>
Co-authored-by: Andrews Arokiam <[email protected]>
Co-authored-by: andyi2it <[email protected]>
Co-authored-by: Chin Huang <[email protected]>
Co-authored-by: Qingshan Chen <[email protected]>
Co-authored-by: Animesh Singh <[email protected]>
Co-authored-by: js-ts <[email protected]>
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
Make sure that no fewer KFP DSL scripts pass
the compilation than before

Add Python linter to Travis
HumairAK pushed a commit to HumairAK/data-science-pipelines that referenced this issue Jul 4, 2024
Revert "UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests